Hi Michael,
The changes look good.
-Tom
Michael Bouschen wrote:
>H Tom,
>
>attached you find my changes to validate the SELECT clause in case of a
>GROUP BY query. This makes sure that a GROUP BY query only returns
>grouping items or aggregates. The corresponding glassfish issue is:
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=166
>Please note, the change also includes checking the HAVING expression.
>I needed to redefine the getAsString method in a couple of parser tree
>nodes in order to give a better error message and might need to do the
>same change for more nodes. But this can be added later.
>
>Thanks!
>
>Regards Michael
>
>
>
>
--
Tom Ware
Principal Software Engineer
Oracle Canada Inc.
Direct: (613) 783-4598
Email: tom.ware_at_oracle.com