persistence@glassfish.java.net

Re: Code review for completion of issue 158

From: Tom Ware <tom.ware_at_oracle.com>
Date: Wed, 15 Feb 2006 16:22:59 -0500

Hi Pramod,

  As long as the datatypes test will be part of the regular testing and
eventually checked in. I think that test will suffice.

-Tom

Pramod Gopinath wrote:

>Hi Tom
> The datatypes test is part of the SQE test suite that are supposed to
>be checked in.
>
>The ejbDatatypes test that I am referring to is part of the sqe test
>suite being used by our sqe test folks internally to report bugs. The
>sqe test framework would create an ear file, deploy the ear to the
>application server and then run their client part. The tests can be run
>with and w/o the java2db part turned on. In case it is being run in the
>non java2db mode the run sql scripts to create the tables before
>deploying the applicating. In the case of java2db the test would create
>the tables as part of the deployment cycle itself.
>I guess this behavior is similar to the cts testing case.
>
>Thanks
>Pramod
>
>
>Tom Ware wrote:
>
>
>>Where is this datatype model? How is it run?
>>
>>-Tom
>>
>>Pramod Gopinath wrote:
>>
>>
>>
>>>Hi Tom
>>> Our SQL team has a datatypes test that I have been using for
>>>creating the standard datatypes and ensuring that the maximum values
>>>can be inserted into them. I have been using this test to confirm my
>>>changes.
>>> Do we need to additionally need to add regression tests ? What are
>>>your ideas on this issue ?
>>>
>>>Thanks
>>>Pramod
>>>
>>>
>>>Tom Ware wrote:
>>>
>>>
>>>
>>>
>>>>Hi Pramod,
>>>>
>>>>The change to PostGreSQLPlatform looks fine. Is it possible to add
>>>>a regression test?
>>>>
>>>>-Tom
>>>>
>>>>Pramod Gopinath wrote:
>>>>
>>>>
>>>>
>>>>
>>>>>Hi Tom
>>>>>For issue 158 to be solved completely I had to make a change to the
>>>>>PostgreSQLPlatform file.
>>>>>This is to ensure that we correctly create a "boolean" field in
>>>>>postgresql for a java.lang.Boolean type. Also had to ensure that we
>>>>>correctly insert a value of '1' or '0' to indicate a value of true
>>>>>and false.
>>>>>
>>>>>Could you also review this change so that I could check it in
>>>>>together.
>>>>>
>>>>>Thanks
>>>>>Pramod
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>
>>>
>>>
>>>

-- 
Tom Ware
Principal Software Engineer
Oracle Canada Inc.
Direct: (613) 783-4598
Email: tom.ware_at_oracle.com