persistence@glassfish.java.net

Re: Code review for completion of issue 158

From: Pramod Gopinath <Pramod.Gopinath_at_Sun.COM>
Date: Wed, 15 Feb 2006 12:59:20 -0800

Hi Tom
   Our SQL team has a datatypes test that I have been using for creating
the standard datatypes and ensuring that the maximum values can be
inserted into them. I have been using this test to confirm my changes.
   Do we need to additionally need to add regression tests ? What are
your ideas on this issue ?

Thanks
Pramod


Tom Ware wrote:
> Hi Pramod,
>
> The change to PostGreSQLPlatform looks fine. Is it possible to add a
> regression test?
>
> -Tom
>
> Pramod Gopinath wrote:
>
>> Hi Tom
>> For issue 158 to be solved completely I had to make a change to the
>> PostgreSQLPlatform file.
>> This is to ensure that we correctly create a "boolean" field in
>> postgresql for a java.lang.Boolean type. Also had to ensure that we
>> correctly insert a value of '1' or '0' to indicate a value of true
>> and false.
>>
>> Could you also review this change so that I could check it in together.
>>
>> Thanks
>> Pramod
>>
>>
>