persistence@glassfish.java.net

Re: entity-persistence testing fix

From: Tom Ware <tom.ware_at_oracle.com>
Date: Tue, 14 Feb 2006 09:02:36 -0500

Hi Pramod,

  The spec made the change I requested. The final fix will be to remove
that line of code entirely and rely on the fact the the default start
value is now 1. Users that set the start-value to an invalid value for
their DB should get the SQLException.

-Tom

Pramod Gopinath wrote:

>Hi Tom
> There is a problem with the code checked in that deals with the
>changing the initial value to 1 if the user has not defined this annotation.
>
>The changed code in
>src/java/oracle/toplink/essentials/tools/schemframework/OracleSequenceDefinition.java
>
>currently reads
>int startValue = start == 0 ? start : 1;
>
>This should be changed to
>
>int startValue = start == 0 ? 1 : start;
>
>
>Thanks
>Pramod
>
>
>
>Tom Ware wrote:
>
>
>>I have made two updates to entity-persistence.
>>
>>1. Default Oracle Native Sequence initial value to 1 since Oracle does
>>not accept value of 0
>>2. 1 test was not creating its tables prior to running. This caused
>>a failure on a clean DB. This has been fixed.
>>
>>
>>
>
>
>

-- 
Tom Ware
Principal Software Engineer
Oracle Canada Inc.
Direct: (613) 783-4598
Email: tom.ware_at_oracle.com