Hello,
CometEngine.activateContinuation method is protected,
hence preventing overriding in subclasses of cometcontext ( that relies on
the fact that protected is package public)
options to fix this is to make CometEngine.activateContinuation method
public , or add a protected wrapper method in cometcontext.
what do you prefer ?
im to use a custom cometcontext's logic to keep track of loged in users,
therefore i override addCometHandler (default impl. is hiding the result of
handlers.putIfAbsent )
2008/11/4 Jeanfrancois Arcand <Jeanfrancois.Arcand_at_sun.com>
> Salut,
>
> Backport fixes from Grizzly 1.9.0
>>
>> - ALL QL passed (Comet not enabled by default)
>>
>> CVS:
>> ----------------------------------------------------------------------
>> CVS: Issue number:
>> CVS: If this change addresses one or more issues,
>> CVS: then enter the issue number(s) here.
>> CVS: Obtained from:
>> CVS: If this change has been taken from another system,
>> CVS: then name the system in this line, otherwise delete it.
>> CVS: Submitted by:
>> CVS: If this code has been contributed to the project by someone else;
>> i.e.,
>> CVS: they sent us a patch or a set of diffs, then include their
>> name/email
>> CVS: address here. If this is your work then delete this line.
>> CVS: Reviewed by:
>> CVS: If we are doing pre-commit code reviews and someone else has
>> CVS: reviewed your changes, include their name(s) here.
>> CVS: If you have not had it reviewed then delete this line.
>>
>> CVS:
>> ----------------------------------------------------------------------
>> CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
>> CVS:
>> CVS: Committing in .
>> CVS:
>> CVS: Modified Files:
>> CVS: Tag: SJSAS91_FCS_BRANCH
>> CVS:
>> src/java/com/sun/enterprise/web/connector/grizzly/comet/CometAsyncFilter.java
>> CVS:
>> src/java/com/sun/enterprise/web/connector/grizzly/comet/CometContext.java
>> CVS:
>> src/java/com/sun/enterprise/web/connector/grizzly/comet/CometEngine.java
>> CVS:
>> src/java/com/sun/enterprise/web/connector/grizzly/comet/CometSelector.java
>> CVS:
>> src/java/com/sun/enterprise/web/connector/grizzly/comet/DefaultNotificationHandler.java
>> CVS:
>> ----------------------------------------------------------------------
>>
>
> So you can double check I haven't broke anything :-)
>
> A+
>
> -- Jeanfrancois
>
>