persistence@glassfish.java.net

Re: Code review for 1218?

From: Marina Vatkina <Marina.Vatkina_at_Sun.COM>
Date: Wed, 04 Oct 2006 15:53:10 -0700

Tom Ware wrote On 10/04/06 10:06,:
> Hi Marina,
>
> I guess that's a question for the Sun team to decide.
>
> Ignoring that setting is only a problem is the user has set the value
> with the intent of either looking at or using the generated files. If
> the file does not appear where they expect it to be, it could cause them
> problems.

That's what I'm also concerned about.

thanks,
-marina

>
> -Tom
>
> Marina Vatkina wrote:
>
>
>>Hi Tom,
>>
>>Do you see a problem if GF ignores its value and uses internal directories
>>instead?
>>
>>thanks,
>>-marina
>>
>>Tom Ware wrote:
>>
>>
>>
>>>Hi Marina,
>>>
>>>toplink.application-location is by our ddl generation independant of
>>>where we are deployed.
>>>
>>>-Tom
>>>
>>>Marina Vatkina wrote:
>>>
>>>
>>>
>>>
>>>>Hi Pramod,
>>>>
>>>>Then we have another bug, as currently the user's value is used to create
>>>>the files, but not used when the files are read for processing :(.
>>>>
>>>>Tom,
>>>>
>>>>Do you use this property in TopLink integration with other app
>>>>servers? (It
>>>>might be strange if the users have different behavior when using the same
>>>>JPA impl on different app servers).
>>>>
>>>>June,
>>>>
>>>>Is it documented in the docs?
>>>>
>>>>thanks,
>>>>-marina
>>>>
>>>>Pramod Gopinath wrote:
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>>Hi Marina/Jielin
>>>>>The way java2db was designed and implemented the property -
>>>>>"toplink.application-location" was available for a user only in the
>>>>>javaSE environment.
>>>>>
>>>>>In the container environment this property value was maintained by
>>>>>the container. If the user specified a value in
>>>>>"toplink.application-location" this would be ignored. This
>>>>>information is also documented at
>>>>>http://blogs.sun.com/java2dbInGlassFish/entry/automatic_table_generation_feature_in
>>>>>
>>>>>
>>>>>Thanks
>>>>>Pramod
>>>>>
>>>>>
>>>>>Marina Vatkina wrote:
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>>Hi Jielin,
>>>>>>
>>>>>>Good question.
>>>>>>
>>>>>>Team,
>>>>>>
>>>>>>Does anybody have a strong opinion about this?
>>>>>>Should "toplink.application-location" be ignored by GF deployment
>>>>>>and an
>>>>>>internal location be used instead? Or should the location where to
>>>>>>put the
>>>>>>generated files (the property name is probably confusing, but that's a
>>>>>>different story) be preserved?
>>>>>>
>>>>>>I would think that if the user specified the location, they cared about
>>>>>>it. The only problem would be a /tmp where files would disappear after
>>>>>>reboot, but this may be a documentation note.
>>>>>>
>>>>>>thanks,
>>>>>>-marina
>>>>>>
>>>>>>jielin wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>>Hi, Marina,
>>>>>>>
>>>>>>>The code seems okay.
>>>>>>>I have one question for my own learning: for the application
>>>>>>>location defined in persistence.xml, should this location be
>>>>>>>overrided by appserver specified dir in glassfish environment ( I
>>>>>>>mean in EJB container)?
>>>>>>>
>>>>>>>Thanks.
>>>>>>>
>>>>>>>Jielin
>>>>>>>
>>>>>>>Marina Vatkina wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>Hi Jielin,
>>>>>>>>
>>>>>>>>See https://glassfish.dev.java.net/issues/show_bug.cgi?id=1218.
>>>>>>>>
>>>>>>>>Can you please review the attached? TopLink allows you to specify
>>>>>>>>location of the drop/create files, and before this fix, GF code
>>>>>>>>ignored such property
>>>>>>>>when constructing file name for the execution of the jdbc file.
>>>>>>>>
>>>>>>>>thanks,
>>>>>>>>-marina
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>