persistence@glassfish.java.net

Re: Code review for 1218?

From: Pramod Gopinath <Pramod.Gopinath_at_Sun.COM>
Date: Tue, 03 Oct 2006 14:55:20 -0700

Hi Marina/Jielin
  The way java2db was designed and implemented the property -
"toplink.application-location" was available for a user only in the
javaSE environment.

In the container environment this property value was maintained by the
container. If the user specified a value in
"toplink.application-location" this would be ignored. This information
is also documented at
http://blogs.sun.com/java2dbInGlassFish/entry/automatic_table_generation_feature_in

Thanks
Pramod


Marina Vatkina wrote:
> Hi Jielin,
>
> Good question.
>
> Team,
>
> Does anybody have a strong opinion about this?
> Should "toplink.application-location" be ignored by GF deployment and an
> internal location be used instead? Or should the location where to put
> the
> generated files (the property name is probably confusing, but that's a
> different story) be preserved?
>
> I would think that if the user specified the location, they cared about
> it. The only problem would be a /tmp where files would disappear after
> reboot, but this may be a documentation note.
>
> thanks,
> -marina
>
> jielin wrote:
>> Hi, Marina,
>>
>> The code seems okay.
>> I have one question for my own learning: for the application location
>> defined in persistence.xml, should this location be overrided by
>> appserver specified dir in glassfish environment ( I mean in EJB
>> container)?
>>
>> Thanks.
>>
>> Jielin
>>
>> Marina Vatkina wrote:
>>
>>> Hi Jielin,
>>>
>>> See https://glassfish.dev.java.net/issues/show_bug.cgi?id=1218.
>>>
>>> Can you please review the attached? TopLink allows you to specify
>>> location of the drop/create files, and before this fix, GF code
>>> ignored such property
>>> when constructing file name for the execution of the jdbc file.
>>>
>>> thanks,
>>> -marina
>>
>>