Hi Tom,
> Hi Michael,
>
> Changes look good.
Thanks!
>
> I am starting to think we should be adding regression tests to the
> entity-persistence-tests suites as we fix these bugs. What do you think?
Yes, I agree. I have a couple of local tests and maybe they should be
added to the entity-persistence-tests suites. But these tests use their
own test data, so there is some work to check what data is available and
adapt the expected result of the new tests.
I know there are some EJBQL tests in the ejbqltesting package. Do they
include negative tests, I mean a test checking whether the EJBQL
compiler throws an exception for an invalid query?
Regards Michael
>
> -Tom
>
> Michael Bouschen wrote:
>
>> Hi Tom,
>>
>> please have a look at the attached changes of EJBQLParser.g. It allows
>> to access a field having the same name as an EJBQL keyword, e.g
>> ... WHERE e.from = :country
>>
>> The corresponding glassfish issue is:
>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=270
>>
>> Thanks!
>>
>> Regards Michael
>>
>>
>