Hi Bobby,
Bobby Bissett wrote:
>> Bobby Bissett wrote:
>>>> You don't need to use maven. You can use any tools you like and
>>>> use ant's "exec" task to invoke them. But you'll need to let
>>>> me/Terena know what tools are needed to build your module so we can
>>>> set it up in the build system. You can either note that in
>>>> http://wiki.glassfish.java.net/Wiki.jsp?page=ExternalDependencies or
>>>> add that in the module xml file.
>>>
>>> But I can't do that either since the build.xml file explicitly
>>> downloads zip files from the web (including a tomcat zip), unzips
>>> them, and uses those classes at build time. So I can't build the
>>> dependencies and then use them to build javahelp, which is the
>>> intent of the instructions.
>> I don't understand... you mean to build javahelp, you'll need the
>> Apache Tomcat container?
>
> The javahelp build.xml depends on downloading a specific zip file of
> tomcat. To get rid of that, we have to change the way javahelp is
> built. I'd send a link to the build.xml, but, well, what's the point
> right now? I've included a section of build.xml at the end of the email.
If we can change the way javahelp is built, that will be good. (I
know... you're asking about porting. See my response below.)
>
>> Let's start with first level dependency and just buid javahelp for now.
>> Can you list the dependencies that are required to build javahelp
>> here: http://wiki.glassfish.java.net/Wiki.jsp?page=ExternalDependencies
>>
>> and we can determine if we need source for those.
>
> The dependencies are:
> http://www.apache.org/dist/tomcat/tomcat-5/v5.5.20/bin/apache-tomcat-5.5.20.zip
>
> https://jdic.dev.java.net/files/documents/880/5715/jdic-0.8.4.1-bin-windows.zip
>
>
> And, as a bonus, there's a note in build.xml saying that if the above
> jdic url doesn't work, download manually from another location, add
> the zip to a certain directory, and rebuild.
>
> I can't put the above into the format you'd like on the external
> dependencies page. :)
>
We don't want to manually download the zip file. What are these zip
files?
I tried to download apache-tomcat-5.5.20.zip and it failed with "ERROR
404: Not Found." Since this dependency does not exist, then building
javahelp will fail? So, if you can change the build such that it
doesn't depend on this, that will be good.
And jdic-0.8.4.1-bin-windows.zip looks like a Windows specific
dependency. Do we need a Windows system to compile this? Again, if you
don't need to depend on this, that will be good.
>>>
>>>> Is javahelp in an Sun controlled SCM repository. If it is then
>>>> there's no need to port the source over to glassfish's svn external
>>>> repository.
>>>
>>> Yes it is, thus my question -- if it weren't in java.net, I'd just
>>> port the sources. Javahelp can not be built from source, including
>>> dependencies, unless I change the way it's built. (Or unless we want
>>> to control some parts of apache.org, heh heh.) But if I can't change
>>> the way it builds unless I port the sources, right?
>> That's right. If it's not in java.net or kenai then please port the
>> sources. You can change the way it's built. GlassFish v3 build will
>> depend on the binaries from the source build instead of from an
>> external maven repository.
>
Yes, you can change the way it's built. And if you have to port the
source to GlassFish java.net external in order to change the build, then
yes please do so. Please also include the version that you are porting
in the format as external/module/<module-name>/<version> (e.g.
https://glassfish-svn.dev.java.net/svn/glassfish-svn/trunk/external/modules/)
GlassFish v3 build will eventually depend on the javahelp artifact built
from this source.
> Let me try asking another way: what if I have to change the way it's
> built *and* it's in java.net?
>
Hope I answered your question this time :-)
Thanks,
Jane
>> HTH,
>
> Getting closer. :)
>
> Cheers,
> Bobby
>
> p.s. section of build.xml:
>
> <target name="unpack-jdic-jar" description="Download JDIC Jar"
> unless="jdic-jar-present"
> depends="download-jdic-zip">
> <unzip src="${jdic-zip}" dest="${java.io.tmpdir}"/>
> <copy failonerror="true"
> file="${java.io.tmpdir}/jdic-0.8.4.1-bin-windows/jdic.jar"
> tofile="${jdic-jar}"/>
> </target>
>
> <target name="download-jdic-zip" unless="jdic-zip-present">
> <echo>
> Downloading JDIC. If you get an error like 'Server redirected too
> many times' download it manually from
> https://jdic.dev.java.net/servlets/ProjectDocumentView?documentID=5715&showInfo=true
>
> Then copy the zip file to ${jdic-zip} and re-build
> </echo>
> <get
> src="https://jdic.dev.java.net/files/documents/880/5715/jdic-0.8.4.1-bin-windows.zip"
>
> dest="${jdic-zip}"/>
> </target>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>