Jerome Dochez wrote:
Mahesh
Kannan wrote:
Sahoo wrote:
Mahesh, dependencyManagement
Please use dependencyManagement in v3/pom.xml to specify the versions
of various corba artifacts and remove any such external version from
orb/*/pom.xml and send it for review.
I have already checked in the changes since I got the approval from
Jerome.
However, I will make the suggested changes and send it for review
tomorrow.
I am not sure about orb-connector exporting threadpool manager and
IIOPUtils. That is not what a connector module is supposed to be used
for.
Ken / Jerome: Should we create a new module for these two classes?
I just checked the modules directory, we already have 7
glassfish-orb-xxx bundles and we have another 3 orb-xxx bundles so I
would rather avoid creating yet another one. What are the dependencies
of glassfish-corba-orbgeneric module ?
glassfish-corba-orbgeneric depends only on gmbal (and eventually
management-api), because the
threadpool needs to expose some monitoring information. orbgeneric
does not depend on any
glassfish-corba-* or orb-* bundles.
We could probably reduce the number of glassfish-corba-* bundles if
desired, roughly as follows
(I'm omitting the glassfish-corba to save typing):
- asm could be replaced by the copy of ASM 3.x that is used
elsewhere in GFv3
- csiv2 and and omgapi could be combined, but note that the
transactions code needs omgapi but not csiv2 even in the web container
(csiv2 is only about 115K)
- newtimer (51K), codegen (333K), and orbgeneric (145K) could be
combined, but note that codegen is needed by the EJB container even
when the ORB is not used, and orbgeneric (because of the threadpool) is
needed in the webcontainer.
- We could reduce to a orbutil bundle (around 530K), an api bundle
(around 420K), and the orb bundle (1925K) at the cost of somewhat
increasing the footprint of the EJB without ORB and web only scenarious.
I'm not sure if we could reduce the orb-* bundles. Perhaps this could
be moved from 3 to 2, but I don't think we could
get to 1 bundle there.
Ken.