Mahesh Kannan wrote:
> Sahoo wrote:
>> Mahesh, dependencyManagement
>>
>> Please use dependencyManagement in v3/pom.xml to specify the versions
>> of various corba artifacts and remove any such external version from
>> orb/*/pom.xml and send it for review.
> I have already checked in the changes since I got the approval from
> Jerome.
> However, I will make the suggested changes and send it for review
> tomorrow.
>
>>
>> I am not sure about orb-connector exporting threadpool manager and
>> IIOPUtils. That is not what a connector module is supposed to be used
>> for.
>
> Ken / Jerome: Should we create a new module for these two classes?
I just checked the modules directory, we already have 7
glassfish-orb-xxx bundles and we have another 3 orb-xxx bundles so I
would rather avoid creating yet another one. What are the dependencies
of glassfish-corba-orbgeneric module ?
>
> --Mahesh
>
>>
>> Thanks,
>> Sahoo
>>
>> Mahesh Kannan wrote:
>>> Issue#: https://glassfish.dev.java.net/issues/show_bug.cgi?id=10080
>>>
>>> Mahesh Kannan wrote:
>>>> The changes are part of the work to move S1ASThreadPoolManager and
>>>> IIOPUtils from orb-iiop module to orb-connector module.
>>>>
>>>>
>>>> Index: orb-connector/pom.xml
>>>> ===================================================================
>>>> --- orb-connector/pom.xml (revision 32982)
>>>> +++ orb-connector/pom.xml (working copy)
>>>> @@ -27,6 +27,11 @@
>>>> <dependencies>
>>>> <dependency>
>>>> <groupId>com.sun.corba</groupId>
>>>> + <artifactId>glassfish-corba-orbgeneric</artifactId>
>>>> + <version>${glassfish-corba.version}</version>
>>>> + </dependency>
>>>> + <dependency>
>>>> + <groupId>com.sun.corba</groupId>
>>>> <artifactId>glassfish-corba-omgapi</artifactId>
>>>> <version>${glassfish-corba.version}</version>
>>>> </dependency>
>>>>
>>>>
>>>>
>>>> Also, the following changes are required in the osgi.bundle(s).
>>>> Basically, orb-iiop need not export iiop.util package whereas
>>>> orb-connector needs to export iiop.util (since
>>>> S1ASThreadPoolManager has moved to orb-connector).
>>>>
>>>>
>>>> Index: orb-iiop/osgi.bundle
>>>> ===================================================================
>>>> --- orb-iiop/osgi.bundle (revision 32982)
>>>> +++ orb-iiop/osgi.bundle (working copy)
>>>> @@ -1,5 +1,4 @@
>>>> -exportcontents: \
>>>> - org.glassfish.enterprise.iiop.util; \
>>>> org.glassfish.enterprise.iiop.impl;
>>>> version=${project.osgi.version}
>>>>
>>>> ORB-Class-Provider:
>>>> org.glassfish.enterprise.iiop.impl.PEORBConfigurator \
>>>>
>>>>
>>>> Index: orb-connector/osgi.bundle
>>>> ===================================================================
>>>> --- orb-connector/osgi.bundle (revision 32982)
>>>> +++ orb-connector/osgi.bundle (working copy)
>>>> @@ -1,5 +1,6 @@
>>>> -exportcontents: \
>>>> org.glassfish.enterprise.iiop.api; \
>>>> + org.glassfish.enterprise.iiop.util; \
>>>> org.glassfish.enterprise.iiop.spi;
>>>> version=${project.osgi.version} Thanks,
>>>> --Mahesh
>>>>
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>