Thanks Jitu. Your comment mentions excluding methods with
WebServiceFeatures as an arg type. Is that the main thing that needs to
be filtered out? Could there be other params on a method that needs
skipped? Or would WebServiceFeatures be the only parameter for the
methods that need to be filtered out?
thanks,
Ken
Jitendra Kotamraju wrote:
> Ken Hofsass wrote:
>
>> Hi Jitu,
>>
>> There were several ws-test-harness changes that were integrated from
>> the e2e harness workspace into the WSIT workspace at the same time.
>> The wsrm dispatch test can be made to pass by reverting to the
>> previous revision of the test jars. Your change was just one of
>> them. It could easily be one of the other harness changes or
>> something with the new build of BSH.
>>
>> So, mostly I was just wondering if somehow if it might accidentally
>> be exluding the dispatch method that's supposed to be called somehow.
>> Do you think that is likely/possible?
>
> Yes it is possible. Since the fix at present just checks if the
> arguments for a method >0, then it doesn't use that method. The proper
> fix would be to look for the types of the argument, and based on it to
> take a decision.
>
> Jitu
>
>>
>> thanks,
>> Ken
>>
>> Jitendra Kotamraju wrote:
>>
>>> Ken Hofsass wrote:
>>>
>>>> My apologies Rama. I should have re-checked the CVS emails. You
>>>> certainly did not make that change. It was actually Jitu who made
>>>> the change I had in mind (to ClientExecutor.java).
>>>
>>>
>>> Yes, I have put a change to exclude methods like
>>> getHelloPort(WebServiceFeatures ... ) while injecting the ports into
>>> the bsh.
>>>
>>> Jitu
>>>
>>>>
>>>> sorry for the confusion,
>>>> Ken
>>>>
>>>> Rama Pulavarthi wrote:
>>>>
>>>>> Hi Ken,
>>>>> I am not sure if i put any code to exclude some methods.
>>>>> Which file has the suspected change?
>>>>>
>>>>> thanks,
>>>>> Rama Pulavarthi
>>>>>
>>>>> Ken Hofsass wrote:
>>>>>
>>>>>> I was thinking, it might be an issue with one of the fixes that
>>>>>> Rama put in to exclude certain methods from being included in the
>>>>>> namespace. Maybe not, but I was thinking of looking there to
>>>>>> confirm. -- Ken
>>>>>>
>>>>>> Kohsuke Kawaguchi wrote:
>>>>>>
>>>>>>> Ken Hofsass wrote:
>>>>>>>
>>>>>>>> Kohsuke,
>>>>>>>>
>>>>>>>> The wsrm/dispatch test works with the previous revision of
>>>>>>>> BSH/harness jars (Bhakti's machine, my machine) but fails
>>>>>>>> consisitently with the new ones (my machine, Hudson).
>>>>>>>>
>>>>>>>> It could be our internal changes or could be the new BSH that
>>>>>>>> was integrated. Could you take a look at the test output, see
>>>>>>>> if anything sticks out? If not, I'll debug into things further.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> OK. I'll take a look.
>>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_ws-test-harness.dev.java.net
>>>>>> For additional commands, e-mail:
>>>>>> dev-help_at_ws-test-harness.dev.java.net
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_ws-test-harness.dev.java.net
>>>>> For additional commands, e-mail:
>>>>> dev-help_at_ws-test-harness.dev.java.net
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_ws-test-harness.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_ws-test-harness.dev.java.net
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_ws-test-harness.dev.java.net
>>> For additional commands, e-mail: dev-help_at_ws-test-harness.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_ws-test-harness.dev.java.net
>> For additional commands, e-mail: dev-help_at_ws-test-harness.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_ws-test-harness.dev.java.net
> For additional commands, e-mail: dev-help_at_ws-test-harness.dev.java.net
>