Linda,
Thanks for the update. I was mostly refering to existing elements of the
spec and where necessary the Java Language or Naming Guidelines most of
which by Sun/Oracle.
What should XXX be, a number or some other word?
If I see it correctly the interface inheritance should be:
AbstractCriteria*
|
¯*Update*
¯*Delete*
If that's the case, either those children should have "Criteria" at the end
of the name, or as an alternative "XXX" might be "Base". In which case the
obvious "Abstract" best be dropped and the abstract Base interface might be
called "CriteriaBase" having Criteria* interfaces as children.
HTH,
Werner
----- Original Message -----
From: "Linda DeMichiel" <linda.demichiel_at_oracle.com>
To: <jsr338-experts_at_jpa-spec.java.net>
Cc: <kwesi_at_sap.com>
Sent: Tuesday, April 05, 2011 2:58 AM
Subject: [jsr338-experts] Re: [jpa-spec users] Re: criteria API bulk
update/delete
> Hmmmm.....
>
> Perhaps my native American English has been corrupted by a number of
> years studying other languages as well as by computer-ese :-), but I
> thought CriteriaUpdate and CriteriaDelete were no less clear than the
> corresponding JPQL Update and JPQL Delete. I had suggested them with
> the intent that they be understood as nouns, like CriteriaQuery, with
> "statement" or "operation" being implicitly understood, and "Criteria"
> serving an adjectival role. UpdateCriteria and DeleteCriteria I parse
> as verbs, which I don't think is consistent with our naming scheme for
> interfaces.
>
> Perhaps instead of AbstractCriteria, we could use AbstractCriteriaXXX
> for some value of XXX.
>
> More ideas, please....
>
> thanks again,
>
> Linda
>
>
> On 4/4/2011 1:55 PM, Werner Keil wrote:
>> Method seems fine, but as mentioned earlier, if both classes/interfaces
>> inherit from AbstractCriteria they should be called
>> UpdateCriteria and DeleteCriteria.
>>
>> CriteriaQuery has nothing to do with it, since both CriteriaQuery and the
>> slightly unusual Subquery inherit from AbstractQuery.
>> We should follow that pattern not only because of consistency in the API
>> but some of the most basic Java Naming Conventions.
>>
>> *Criteria is for a specialized Criteria, like UpdateCriteria, while if
>> you call something CriteriaUpdate that would signal a (user) Action to
>> update Criteria.
>> I don't think that is what those new types intend to do, so please let's
>> call them what they intend to do.
>>
>> Kind Regards,
>> Werner
>>
>> ----- Original Message ----- From: "Linda DeMichiel"
>> <linda.demichiel_at_oracle.com>
>> To: <kwesi_at_sap.com>
>> Cc: <jsr338-experts_at_jpa-spec.java.net>
>> Sent: Tuesday, April 05, 2011 1:02 AM
>> Subject: [jsr338-experts] Re: [jpa-spec users] Re: criteria API bulk
>> update/delete
>>
>>
>>>
>>>
>>> On 4/4/2011 1:05 AM, Rainer Kwesi Schweigkoffer wrote:
>>>> Linda, Michael, all,
>>>>
>>>> Michael Bouschen, am 3 Apr 2011 hast Du um 22:35 zum Thema
>>>> "[jsr338-experts] Re: criteria API b" geschrieben :
>>>>
>>>>> I like the names CriteriaUpdate, CriteriaDelete and AbstractCriteria.
>>>>
>>>> For the CriteriaUpdate interface, I guess, we would need another method
>>>>
>>>> CriteriaUpdate<T> set(String attributeName, Object value);
>>>>
>>>> to enable string-based usage.
>>>>
>>>
>>> Yes -- thanks!
>>>
>>> -Linda
>>>
>>>> Kind regards
>>>> Rainer
>>>>
>>>> ---
>>>> Rainer Schweigkoffer SAP AG Walldorf
>>>> Business Solution & Technology TD Core JS&I
>>>> Technology Development Dietmar-Hopp-Allee 16
>>>> Java Server Core D-69190 Walldorf
>>>> JEE Implementation Group phone: +49 6227 7 45305
>>>> Building 3, I.3.14 fax: +49 6227 7 821177
>>>> rainer.schweigkoffer_at_sap.com
>>>>
>>>> Sitz der Gesellschaft/Registered Office: Walldorf, Germany
>>>> Vorstand/SAP Executive Board: Werner Brandt, Angelika Dammann,
>>>> Bill McDermott (Co-CEO), Gerhard Oswald, Vishal Sikka,
>>>> Jim Hagemann Snabe (Co-CEO)
>>>> Vorsitzender des Aufsichtsrats/Chairperson of the SAP Supervisory
>>>> Board: Hasso Plattner
>>>> Registergericht/Commercial Register Mannheim No HRB 350269
>>>>
>>>> Diese E-Mail kann Betriebs- oder Geschaeftsgeheimnisse oder sonstige
>>>> vertrauliche Informationen enthalten. Sollten Sie diese E-Mail
>>>> irrtuemlich erhalten haben, ist Ihnen eine Verwertung des Inhalts, eine
>>>> Vervielfaeltigung oder Weitergabe der E-Mail ausdruecklich untersagt.
>>>> Bitte benachrichtigen Sie uns und vernichten Sie die empfangene E-Mail.
>>>> Vielen Dank.
>>>>
>>>> This e-mail may contain trade secrets or privileged, undisclosed, or
>>>> otherwise confidential information. If you have received this e-mail in
>>>> error, you are hereby notified that any review, copying, or
>>>> distribution of it is strictly prohibited. Please inform us immediately
>>>> and destroy the original transmittal. Thank you for your cooperation.
>>>>