dev@grizzly.java.net

Re: Should ServletAdapter.destroy() destroy wrapped HttpServlet?

From: Jeanfrancois Arcand <Jeanfrancois.Arcand_at_Sun.COM>
Date: Thu, 03 Sep 2009 10:13:03 -0400

Salut,

Oleksiy Stashok wrote:
> Hi,
>
> currently in out implementation, it looks like when I call
> ServletAdapter.destroy(), it doesn't destroy wrapped servlet (doesn't
> call HttpServlet.destroy()).
> Is it correct behavior?

Agree. The fix should be in FilterChainImpl:

> Index: src/main/java/com/sun/grizzly/http/servlet/FilterChainImpl.java
> ===================================================================
> --- src/main/java/com/sun/grizzly/http/servlet/FilterChainImpl.java (revision 3573)
> +++ src/main/java/com/sun/grizzly/http/servlet/FilterChainImpl.java (working copy)
> @@ -252,6 +252,7 @@
> if (filter != null)
> filter.recycle();
> }
> + servlet.destroy();
> filters = null;
> }
> }

Good catch. Can you file an issue :-)

A+

-- Jeanfrancois

>
> WBR,
> Alexey.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_grizzly.dev.java.net
> For additional commands, e-mail: dev-help_at_grizzly.dev.java.net
>