dev@grizzly.java.net

Re: servletadapter.start hides exceptions

From: gustav trede <gustav.trede_at_gmail.com>
Date: Wed, 28 Jan 2009 21:09:12 +0100

2009/1/28 Hubert Iwaniuk <neotyk_at_kungfoo.pl>

> Hi,
> Comment inline
>
> On Wed, Jan 28, 2009 at 8:43 PM, Jeanfrancois Arcand <
> Jeanfrancois.Arcand_at_sun.com> wrote:
>
>> Salut,
>>
>> gustav trede wrote:
>>
>>> hell,
>>>
>>> servletadapter.start() hides exceptions.
>>>
>>> If the servlet.init or so fails , httpservice.registerServlet should be
>>> able to detect it and abort the servlet registration ,
>>> leaving the alias free to use instead of locked by an invalid servlet ?
>>>
>>
>> I agree we need to fix that. I would change two things:
>>
>> (1) Throw a RuntmeException instead of just logging the exception.
>
>
> HttpService when registering needs to throw ServletException if provided
> Servlet.init() throws it.
>
>
yes. so catch runtimeException and rethrow a new servletexception.


-- 
regards
 gustav trede