Hi,
Comment inline
On Wed, Jan 28, 2009 at 8:43 PM, Jeanfrancois Arcand <
Jeanfrancois.Arcand_at_sun.com> wrote:
> Salut,
>
> gustav trede wrote:
>
>> hell,
>>
>> servletadapter.start() hides exceptions.
>>
>> If the servlet.init or so fails , httpservice.registerServlet should be
>> able to detect it and abort the servlet registration ,
>> leaving the alias free to use instead of locked by an invalid servlet ?
>>
>
> I agree we need to fix that. I would change two things:
>
> (1) Throw a RuntmeException instead of just logging the exception.
HttpService when registering needs to throw ServletException if provided
Servlet.init() throws it.
>
> (2) Make sure the GrizzlyWebServer/GrizzlyAdapterChain catch those
> exception and logs them and still be able to start other Adapter added.
>
> Thanks
>
> -- Jeanfrancois
>
>
>
>> Either throwing the Throwable or returning a boolean status flag should
>> work.
>>
>> whats your opinion ?
>>
>> --
>> regards
>> gustav trede
>>
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_grizzly.dev.java.net
> For additional commands, e-mail: dev-help_at_grizzly.dev.java.net
>
>