On 02/05/09 13:47, Wolfram Rittmeyer wrote:
> Jan Luehe wrote:
>> Hallo Wolfram,
>>
> (...)
>>
>> Please see attachments for my comments (each marked with "-> WOLFRAM").
>> Let me know what you think, and if you would like to incorporate them
>> into an
>> updated version of your patch.
>>
>
> Hi Jan,
>
> thanks for your detailed comments. Of course I would like to
> incorparate them and provide an updated patch. Thanks to your detailed
> comments I should be able to incorporate them shortly after the
> weekend. This weekend I'm in Brussels at the FOSDEM - so I probably
> won't have much time for this ;-)
>
>> Thanks also for providing a unit test case! To answer your question on
>> how to transfer it to us, why not attach it to the issue you filed:
>>
>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=4006
>> ("Add more flexible configuration possibilies for Valves")
>>
>> I could then pick it up from there.
>>
>
> I will do so, as soon as I have submitted the changed patch.
Sounds great, Wolfram!
I also realized that we should probably upgrade the version of the
sun-web.xml
DTD.
Traditionally, we've kept its version in sync with that of web.xml.
Therefore, I would suggest that we add support for <valve> to
sun-web-app_3_0-0.dtd instead of sun-web-app_2_5-0.dtd.
I will see what's involved in making this change and will let you know.
Looking forward to your updated diffs.
Thanks,
Jan