Jan Luehe wrote:
> Hallo Wolfram,
>
(...)
>
> Please see attachments for my comments (each marked with "-> WOLFRAM").
> Let me know what you think, and if you would like to incorporate them
> into an
> updated version of your patch.
>
Hi Jan,
thanks for your detailed comments. Of course I would like to incorparate
them and provide an updated patch. Thanks to your detailed comments I
should be able to incorporate them shortly after the weekend. This
weekend I'm in Brussels at the FOSDEM - so I probably won't have much
time for this ;-)
> Thanks also for providing a unit test case! To answer your question on
> how to transfer it to us, why not attach it to the issue you filed:
>
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=4006
> ("Add more flexible configuration possibilies for Valves")
>
> I could then pick it up from there.
>
I will do so, as soon as I have submitted the changed patch.
Thanks,
Wolfram
> Thanks!
>
> Jan
>