Hallo Wolfram,
On 02/04/09 20:33, Jan Luehe wrote:
> On 02/04/09 09:56, Wolfram Rittmeyer wrote:
>> w.rittmeyer_at_jsptutorial.org wrote:
>>> Oops. The classes
>>> com.sun.enterprise.deployment.node.runtime.web.ValveNode and
>>> com.sun.enterprise.deployment.runtime.web.Valve are missing
>>> (deployment). I will add them this evening (MEZ).
>>>
>>
>> And finally these two classes ;-)
>
> Hi Wolfram,
>
> congrats on your first web related GlassFish patch!
>
> I've looked through your diffs and found no issues.
> Great work!
>
> I have a few minor comments which I am going to mail to you
> tomorrow.
Please see attachments for my comments (each marked with "-> WOLFRAM").
Let me know what you think, and if you would like to incorporate them
into an
updated version of your patch.
Thanks also for providing a unit test case! To answer your question on
how to transfer it to us, why not attach it to the issue you filed:
https://glassfish.dev.java.net/issues/show_bug.cgi?id=4006
("Add more flexible configuration possibilies for Valves")
I could then pick it up from there.
Thanks!
Jan