quality@glassfish.java.net

Re: My first tests with FishCAT ...ouch

From: Jan Luehe <Jan.Luehe_at_Sun.COM>
Date: Wed, 25 Nov 2009 13:04:53 -0800

Hi Jose,

On 11/25/09 10:40, Jose Noheda wrote:
> Hi Jan,
>
> May be it's caused by some (minimal) changes that HEAD includes? Could
> you checkout */http/*://internna.googlecode.com/svn/trunk/IWebMvc2
> <http://internna.googlecode.com/svn/trunk/IWebMvc2> and try it yourself?

Done, and with the generated WAR, I was indeed able to reproduce the NPE.
I've filed https://glassfish.dev.java.net/issues/show_bug.cgi?id=11182
and added
you to its cc list.

> I've fixed the issues that prevented the Maven build so it should be
> pretty straight forward: mvn clean install at root folder and then
> from Netbeans open and run the demo project (check the pool deployment
> option in the GFv3 server first).
>
> I didn't mention it again but I still can't see the logs (I see blank
> lines). It could be a GF configuration issue (not sure why should I
> configure anything in GF to have log4j running though) or some other
> problem..what's your opinion?
>

Unfortunately, I don't know the answer to this. I've added Carla, in
case she has any idea.

Thanks,

Jan





> Regards
>
> On Wed, Nov 25, 2009 at 6:40 PM, Jan Luehe <Jan.Luehe_at_sun.com
> <mailto:Jan.Luehe_at_sun.com>> wrote:
>
> On 11/24/09 23:30, Judy Tang wrote:
>> "The second time (just pressing F5) the page works fine. IIRC
>> this is the exact same behavior I got with Tomcat with versions
>> prior 6.0.20 (with 6.0.18 for example). The bug is fixed in
>> Tomcat now so it may just be a matter of identifying the patch."
>>
>> Wow, not only report the issue, but also points out what could be
>> the cause, thanks Jose for continue testing, I am sure Jan will
>> get back to you soon :-)
>
> Jose, thanks for picking up the nightly and testing it with your app!
>
> I just downloaded the nightly myself and deployed your app.
> When I access the FILTERED GRID link for the first time, the page
> compiles just fine, and I don't see the stacktrace you mentioned.
>
> The line where you are getting an NPE (ReflectUtil.java:101) looks
> like this:
>
> public static void checkPackageAccess(Class clazz) {
> checkPackageAccess(clazz.getName());
> }
>
> which means "clazz" is null. I've cc'ed Kin-man in case he has any
> ideas what
> might be causing this. Thanks for narrowing down the range of TC
> releases
> for a possible fix.
>
> It looks like we're almost there, though. :)
>
> Jan
>
>
>
>>
>> Thanks,
>> Judy
>>
>> Jose Noheda wrote:
>>> Hi Jan,
>>>
>>> I tested today's nightly and I'm getting this exception the
>>> first time I access the filtered grid link:
>>>
>>> java.lang.NullPointerException
>>> at
>>> sun.reflect.misc.ReflectUtil.checkPackageAccess(ReflectUtil.java:101)
>>> at
>>> sun.reflect.misc.ReflectUtil.isPackageAccessible(ReflectUtil.java:123)
>>> at
>>> java.beans.Introspector.getBeanInfo(Introspector.java:154)
>>> at
>>> org.apache.jasper.compiler.Generator$TagHandlerInfo.<init>(Generator.java:3893)
>>> at
>>> org.apache.jasper.compiler.Generator$GenerateVisitor.getTagHandlerInfo(Generator.java:2241)
>>> at
>>> org.apache.jasper.compiler.Generator$GenerateVisitor.visit(Generator.java:1640)
>>> at
>>> org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1501)
>>> at
>>> org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2302)
>>> at
>>> org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2352)
>>> at
>>> org.apache.jasper.compiler.Generator$GenerateVisitor.generateJspFragment(Generator.java:3187)
>>> at
>>> org.apache.jasper.compiler.Generator$GenerateVisitor.generateCustomDoTag(Generator.java:2537)
>>> at
>>> org.apache.jasper.compiler.Generator$GenerateVisitor.visit(Generator.java:1723)
>>> at
>>> org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1501)
>>> at
>>> org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2302)
>>> at
>>> org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2352)
>>> at
>>> org.apache.jasper.compiler.Generator$GenerateVisitor.generateJspFragment(Generator.java:3187)
>>> at
>>> org.apache.jasper.compiler.Generator$GenerateVisitor.generateCustomDoTag(Generator.java:2537)
>>> at
>>> org.apache.jasper.compiler.Generator$GenerateVisitor.visit(Generator.java:1723)
>>> at
>>> org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1501)
>>> at
>>> org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2302)
>>> at
>>> org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2352)
>>> at
>>> org.apache.jasper.compiler.Node$Visitor.visit(Node.java:2358)
>>> at
>>> org.apache.jasper.compiler.Node$Root.accept(Node.java:498)
>>> at
>>> org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2302)
>>> at
>>> org.apache.jasper.compiler.Generator.generate(Generator.java:3469)
>>> at
>>> org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:251)
>>> at
>>> org.apache.jasper.compiler.Compiler.compile(Compiler.java:447)
>>> at
>>> org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:620)
>>> at
>>> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:379)
>>> at
>>> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:483)
>>> at
>>> org.apache.jasper.servlet.JspServlet.service(JspServlet.java:373)
>>> at
>>> javax.servlet.http.HttpServlet.service(HttpServlet.java:847)
>>> at
>>> org.apache.catalina.core.StandardWrapper.service(StandardWrapper.java:1523)
>>> at
>>> org.apache.catalina.core.ApplicationDispatcher.doInvoke(ApplicationDispatcher.java:802)
>>> at
>>> org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:664)
>>> at
>>> org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:497)
>>> at
>>> org.apache.catalina.core.ApplicationDispatcher.doDispatch(ApplicationDispatcher.java:468)
>>> at
>>> org.apache.catalina.core.ApplicationDispatcher.dispatch(ApplicationDispatcher.java:364)
>>> at
>>> org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:314)
>>> at
>>> org.springframework.web.servlet.view.InternalResourceView.renderMergedOutputModel(InternalResourceView.java:236)
>>> at
>>> org.springframework.web.servlet.view.AbstractView.render(AbstractView.java:257)
>>> at
>>> org.springframework.web.servlet.DispatcherServlet.render(DispatcherServlet.java:1183)
>>> at
>>> org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:902)
>>> at
>>> org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:807)
>>> at
>>> org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:571)
>>> at
>>> org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:501)
>>> at
>>> javax.servlet.http.HttpServlet.service(HttpServlet.java:734)
>>> at
>>> javax.servlet.http.HttpServlet.service(HttpServlet.java:847)
>>> at
>>> org.apache.catalina.core.StandardWrapper.service(StandardWrapper.java:1523)
>>> at
>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:343)
>>> at
>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:215)
>>> at
>>> org.springframework.security.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:378)
>>> at
>>> org.springframework.security.ui.rememberme.RememberMeProcessingFilter.doFilterHttp(RememberMeProcessingFilter.java:109)
>>> at
>>> org.springframework.security.ui.SpringSecurityFilter.doFilter(SpringSecurityFilter.java:53)
>>> at
>>> org.springframework.security.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:390)
>>> at
>>> org.springframework.security.ui.AbstractProcessingFilter.doFilterHttp(AbstractProcessingFilter.java:277)
>>> at
>>> org.springframework.security.ui.SpringSecurityFilter.doFilter(SpringSecurityFilter.java:53)
>>> at
>>> org.springframework.security.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:390)
>>> at
>>> org.springframework.security.intercept.web.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:109)
>>> at
>>> org.springframework.security.intercept.web.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:83)
>>> at
>>> org.springframework.security.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:390)
>>> at
>>> org.springframework.security.ui.ExceptionTranslationFilter.doFilterHttp(ExceptionTranslationFilter.java:101)
>>> at
>>> org.springframework.security.ui.SpringSecurityFilter.doFilter(SpringSecurityFilter.java:53)
>>> at
>>> org.springframework.security.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:390)
>>> at
>>> org.springframework.security.ui.logout.LogoutFilter.doFilterHttp(LogoutFilter.java:89)
>>> at
>>> org.springframework.security.ui.SpringSecurityFilter.doFilter(SpringSecurityFilter.java:53)
>>> at
>>> org.springframework.security.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:390)
>>> at
>>> org.springframework.security.context.HttpSessionContextIntegrationFilter.doFilterHttp(HttpSessionContextIntegrationFilter.java:235)
>>> at
>>> org.springframework.security.ui.SpringSecurityFilter.doFilter(SpringSecurityFilter.java:53)
>>> at
>>> org.springframework.security.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:390)
>>> at
>>> org.springframework.security.util.FilterChainProxy.doFilter(FilterChainProxy.java:175)
>>> at
>>> org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:236)
>>> at
>>> org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:167)
>>> at
>>> org.internna.iwebmvc.spring.jee.IWebMvcCombinedFilter.doFilter(IWebMvcCombinedFilter.java:139)
>>> at
>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:256)
>>> at
>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:215)
>>> at
>>> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:277)
>>> at
>>> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:188)
>>> at
>>> org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:641)
>>> at
>>> com.sun.enterprise.web.WebPipeline.invoke(WebPipeline.java:97)
>>> at
>>> com.sun.enterprise.web.PESessionLockingStandardPipeline.invoke(PESessionLockingStandardPipeline.java:85)
>>> at
>>> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:185)
>>> at
>>> org.apache.catalina.connector.CoyoteAdapter.doService(CoyoteAdapter.java:332)
>>> at
>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:233)
>>> at
>>> com.sun.enterprise.v3.services.impl.ContainerMapper.service(ContainerMapper.java:165)
>>> at
>>> com.sun.grizzly.http.ProcessorTask.invokeAdapter(ProcessorTask.java:791)
>>> at
>>> com.sun.grizzly.http.ProcessorTask.doProcess(ProcessorTask.java:693)
>>> at
>>> com.sun.grizzly.http.ProcessorTask.process(ProcessorTask.java:954)
>>> at
>>> com.sun.grizzly.http.DefaultProtocolFilter.execute(DefaultProtocolFilter.java:168)
>>> at
>>> com.sun.grizzly.DefaultProtocolChain.executeProtocolFilter(DefaultProtocolChain.java:135)
>>> at
>>> com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:102)
>>> at
>>> com.sun.grizzly.DefaultProtocolChain.execute(DefaultProtocolChain.java:88)
>>> at
>>> com.sun.grizzly.http.HttpProtocolChain.execute(HttpProtocolChain.java:76)
>>> at
>>> com.sun.grizzly.ProtocolChainContextTask.doCall(ProtocolChainContextTask.java:53)
>>> at
>>> com.sun.grizzly.SelectionKeyContextTask.call(SelectionKeyContextTask.java:57)
>>> at com.sun.grizzly.ContextTask.run(ContextTask.java:69)
>>> at
>>> com.sun.grizzly.util.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:330)
>>> at
>>> com.sun.grizzly.util.AbstractThreadPool$Worker.run(AbstractThreadPool.java:309)
>>> at java.lang.Thread.run(Thread.java:619)
>>>
>>> The second time (just pressing F5) the page works fine. IIRC
>>> this is the exact same behavior I got with Tomcat with versions
>>> prior 6.0.20 (with 6.0.18 for example). The bug is fixed in
>>> Tomcat now so it may just be a matter of identifying the patch.
>>>
>>> Regards
>>>
>>> On Sat, Nov 21, 2009 at 12:07 AM, Jan Luehe <Jan.Luehe_at_sun.com
>>> <mailto:Jan.Luehe_at_sun.com>> wrote:
>>>
>>> Jose,
>>>
>>> I wanted to update you with some good news:
>>>
>>> Kin-man was able to spot a code line in the JSP compiler
>>> that looked
>>> like it was causing tag files that are bundled in JAR files
>>> (as is the case
>>> with IWebMvc2-Final_RC) to be compiled over and over again.
>>> The same code line had been present in earlier Tomcat
>>> releases , but had
>>> been removed in the latest Tomcat release. We looked through
>>> the Tomcat
>>> history of this particular file and found that the line had
>>> been removed as part
>>> of the fix for this issue:
>>>
>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=43741
>>> (".tag files in a .jar recompiled for each .jsp --
>>> extremely slow")
>>>
>>> BINGO!
>>>
>>> Kin-man has applied a similar fix to GlassFish, and we've
>>> verified
>>> that was used to take 8 minutes now takes a mere 10-15 seconds,
>>> which is in line with the number you had given us.
>>>
>>> A big "Thank You!" goes to Kin-man!!
>>>
>>> The fix will be available with the next promoted build (and
>>> earlier
>>> nightlies).
>>>
>>> Also, it looks like the only other remaining issue you filed:
>>>
>>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=11082
>>> ("Deployment error with Quartz job")
>>>
>>> has been closed as invalid, because the evaluator suspected
>>> that it
>>> was an issue with the application itself, and you agreed to take
>>> another look at it.
>>>
>>> So I guess this means we're all set? :-)
>>>
>>> Thanks,
>>>
>>>
>>> Jan
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail:
>>> quality-unsubscribe_at_glassfish.dev.java.net
>>> <mailto:quality-unsubscribe_at_glassfish.dev.java.net>
>>> For additional commands, e-mail:
>>> quality-help_at_glassfish.dev.java.net
>>> <mailto:quality-help_at_glassfish.dev.java.net>
>>>
>>>
>
>