Hi Gordon,
I removed that method because there is no longer a need to *override*
the superclass implementation. I think, it was earlier overridden
because PMTransactionManager was not allowing setRollbackOnly() to be
called directly. Now we are using a different TM which supports this
operations.
Thanks for reviewing,
Sahoo
Gordon Yorke wrote:
> Hello Sahoo,
> Looks fine to me, I see you removed the setRollBackOnly_impl method? Is that no longer required?
> --Gordon
>
> -----Original Message-----
> From: Sanjeeb.Sahoo_at_Sun.COM [mailto:Sanjeeb.Sahoo_at_Sun.COM]On Behalf Of
> Sanjeeb Kumar Sahoo
> Sent: Friday, October 13, 2006 2:15 PM
> To: Yorke Gordon J
> Cc: persistence_at_glassfish.dev.java.net
> Subject: Code review for issue #1299
>
>
> Hi Gordon,
>
> Would you mind reviewing the changes for
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=1299 ?
>
> Thanks,
> Sahoo
>
>