persistence@glassfish.java.net

Re: Code review for issue 691

From: Tom Ware <tom.ware_at_oracle.com>
Date: Thu, 24 Aug 2006 10:33:15 -0400

Hi Markus,

  The changes look good.

  The reason Long and Long Raw were created is that old version of
Oracle needed those types. Since those versions are now quite old, I
see no problem with changing those defaults in essentials.

-Tom

Markus Fuchs wrote:

>Hi Tom,
>
>Issue 691 is about Java2DB creating a table having two LONG fields on
>Oracle. Oracle does not permit to create such a table, and the test
>fails. The entity in the test has two fields that are annotated @Lob,
>
> @Lob
> @Column(name = "BLOBDATA")
> public byte[] getBlobData(){
>
>and
>
> @Lob
> @Column(name = "CLOBDATA")
> public String getClobData(){
>
>Because of the @Lob annotation, these fields are recognized by TopLink
>as type java.sql.Blob and java.sql.Clob respectively. I've changed
>OraclePlatform to register column type BLOB and CLOB the these java
>types in fieldTypeMapping, please see attached. After the change, the
>table has a BLOB and a CLOB column, and can be created successfully.
>
>I ran QL and TL unit tests successfully.
>
>Thanks!
>
>-- markus.
>
>

-- 
Tom Ware
Principal Software Engineer
Oracle Canada Inc.
Direct: (613) 783-4598
Email: tom.ware_at_oracle.com