Hi Pramod,
In general your changes look good. 2 comments:
1. EntityManagerFactoryProvider appears to be in the wrong package in
the jars file you sent. I suspect this is just an issue with how you
packaged the jar.
2. Can you modify the comment related to you DDL_GENERATION_MODE check
(lines 214-215 for me) to be something a little more generic. Something
like "Optimize for values explicitly set to NONE".
Thasnk,
Tom
Pramod Gopinath wrote:
>Hi Tom
> I am sending you the changes related to the following issues :
>
>612 : ddl generation feature needs adjustment
> Based on your suggestion the major changes are made to the "cmp"
>module where we have code that deals with application deployment. I have
>ensured that I have "createEntityManager()" call after the
>createEntityManagerFactory() call. With this change in place I have
>removed the method isDdlGenerationRequired() and calls to it.
> File impacted :
>
>glassfish/entity-persistence/src/java/oracle/toplink/essentials/internal/ejb/cmp3/EntityManagerSetupImpl.java
>
>901 : The jdbc files associated with java2db are recreated each time an
>application is loaded
> I am making use of the property
>"toplink.ddl-generation.output-mode", that you had introduced when you
>made the code changes in April-May timeframe.
>The code changes that I have made are as follows :
>1. in the "cmp" module when we are in the application deployment mode,
>I would set the value of the toplink property
>"toplink.ddl-generation.output-mode" to be
>EntityManagerFactoryProvider.DDL_SQL_SCRIPT_GENERATION i.e. "sql-script".
>2. in the "appserv-core" module when we load the application I would
>sent this property to have a value of "none".
>
>With these changes in place on the glassfish side Ido not have to make
>any changes in the "entity-persistence" module. But as part of an
>optimization I just added a check to return from the generateDdlFiles()
>if the value of the property ""toplink.ddl-generation.output-mode" was
>set to "none".
>
>
>Thanks
>Pramod
>
>
--
Tom Ware
Principal Software Engineer
Oracle Canada Inc.
Direct: (613) 783-4598
Email: tom.ware_at_oracle.com