Hi, Romain:
Please see my comments below:
From: Romain Grecourt [mailto:romain.grecourt_at_oracle.com]
Sent: Monday, October 21, 2013 4:14 PM
To: dev_at_glassfish.java.net
Cc: lvsongping
Subject: Re: POM review for the new admin console test suite
Hi Jeremy,
See comments inline.
On 10/17/13 5:16 AM, lvsongping wrote:
Hi， Romain：
Thanks for your careful review and give some of the detailed
feedbacks, please see my comments as follows:
From: Romain Grecourt [mailto:romain.grecourt_at_oracle.com]
Sent: Wednesday, October 16, 2013 10:27 PM
To: dev_at_glassfish.java.net
Cc: lvsongping
Subject: Re: POM review for the new admin console test suite
Hi Jeremy,
Do you plan to add more modules to appserver/tests/admingui ?
If not, please merge the 2 poms into one.
No plan to add more modules to appserver/tests/admingui at this time, but I
think there might be add more modules to appserver/tests/admingui in the
future. That’s the reason why I add two poms here.
Ok, that's fine.
If you keep those two poms, can you define an inheritance and add all
dependencies and plugins version into the dependencyManagement and
pluginManagement section of the parent ?
Also, I'd like to understand this trick:
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
<version>2.7.1</version>
<dependencies>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>surefire-junit47</artifactId>
<version>2.7.1</version>
</dependency>
</dependencies>
<configuration>
<forkMode>never</forkMode>
</configuration>
</plugin>
I have redefined the two poms and attached them again, I have defined an
inheritance and add all dependencies and plugins version into the
dependencyManagement and pluginManagement section of the parent at this
time.
You do define some plugin executions in the parent pom, which would affect
all the sub poms.
That's not important right now, we can rework this later if needed.
Sure
As to the maven-surefire-plugin, this is one of my ubuntu platform’s
network permission that I can’t download the default version of surefire 2.
10. So I just want to make sure there’s no check for the proper
test-frameworks are present on my test project's. Now I have deleted it in
the latest version of pom and it will download the default version of
surefire 2.10 at this time.
Would it work if you 'd depend on surefire 2.7.1 directly ?
Anyway, you can leave it as is but please add a comment to describe the
trick.
Yes, it can be work if it depend on surefire 2.7.1 directly. But I think it
should be use the default surefire, So I will check in the last poms without
add the surefire plugin to the pom.
Feel free to check the poms in.
Ok
Thanks!
Jeremy Lv
Thanks,
Romain
Thanks.
Regards
Jeremy Lv
Thanks,
Romain
On 10/16/13 2:08 PM, lvsongping wrote:
Hi, Romain:
Cc: dev list:
As we have discussed yesterday, the new test suite should be check into
the directory under appserv/tests/admingui module and the POM should be
reviewed first before checked all of the test suites. So please review my
POM I have attached.
regards
Jeremy Lv
--------------------------------------------------
Lv Songping
Software Division II
Development Department I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
ADDR.: No.6 Wenzhu Road, Software Avenue,
Nanjing, 210012, China
TEL : +86+25-86630566-9327
COINS: 7998-9327
FAX : +86+25-83317685
MAIL : <mailto:lvsongping_at_cn.fujitsu.com> lvsongping_at_cn.fujitsu.com
BLOG : <
https://www.java.net/author/jeremy-lv>
https://www.java.net//author/jeremy-lv