Hi， Marina， Shing Wai:
Cc: dev list:
Based on Bill's comments, I should add dev mail list Marina and shing
wai's mail address.
Please review my patch in order to fix the FindBugs about the
CoyoteAdapter.java and BaseContainer.java. Please give me some responses
whether my patch is fine or there's no need to fix these findbugs.
Thanks a lot!
-----Original Message-----
From: Bill Shannon [mailto:bill.shannon_at_oracle.com]
Sent: Wednesday, October 16, 2013 12:42 AM
To: lvsongping; jeremy_lv_at_java.net
Cc: ed.bratt_at_oracle.com; romain.grecourt_at_oracle.com; jill.sato_at_oracle.com;
Rajendra Inamdar
Subject: Re: FindBugs LOW PRIORITY errors in GlassFish open source workspace
[logging] (rev 62784)
In general I would expect changes to fix FindBugs errors to be reviewed the
same as other fixes; mail to dev_at_glassfish.java.net if you don't know where
else to start.
For these particular changes....
The changes to the EJB BaseContainer.java introduce a second Logger to the
file. That doesn't seem appropriate. I suspect other people are being
notified of the other log messages in the same file. Someone ought to fix
all the log messages in that file at the same time, resulting in only one
Logger use in the file. Better yet, all the files in the package would be
fixed at the same time.
CoyoteAdapter.java has already been converted to use the new log message
approach, so the fixes there seem fine.
lvsongping wrote on 10/15/13 3:01 AM:
> Hi, everyone:
>
> Here's attached the patch to fix the following low level findbugs:
> jeremy_lv:
> appserver/web/web-core/src/main/java/org/apache/catalina/connector/Coy
> oteAda
> pter.java:304: GF_MISSING_LOGMESSAGE_INFO_ANNOTATION: Found log
> message ID with missing LogMessageInfo annotation.
> jeremy_lv:
> appserver/web/web-core/src/main/java/org/apache/catalina/connector/Coy
> oteAda
> pter.java:294: GF_MISSING_LOGMESSAGE_INFO_ANNOTATION: Found log
> message ID with missing LogMessageInfo annotation.
> jeremy_lv:
> appserver/ejb/ejb-container/src/main/java/com/sun/ejb/containers/BaseC
> ontain
> er.java:4112: GF_MISSING_LOGMESSAGE_INFO_ANNOTATION: Found log message
> ID with missing LogMessageInfo annotation.
> jeremy_lv:
> appserver/ejb/ejb-container/src/main/java/com/sun/ejb/containers/BaseC
> ontain
> er.java:4102: GF_MISSING_LOGMESSAGE_INFO_ANNOTATION: Found log message
> ID with missing LogMessageInfo annotation.
>
> Anyway, As to the CreateInstanceCommand.java, there's no definition
> about LOGMESSAGE_INFO_ANNOTATION inside, I will regardless of this
particular one.
> BTW, if it is needed to define LOGMESSAGE_INFO_ANNOTATION in the admin
> component, I'd like to do it.
>
> Thanks
>
> Jeremy Lv
>
> -----Original Message-----
> From: Java Release Engineering
> [mailto:java_re_at_sc11136623.us.oracle.com]
> Sent: Monday, October 14, 2013 6:26 PM
> To: jeremy_lv_at_java.net
> Cc: ed.bratt_at_oracle.com; bill.shannon_at_oracle.com;
> romain.grecourt_at_oracle.com; jill.sato_at_oracle.com
> Subject: FindBugs LOW PRIORITY errors in GlassFish open source
> workspace [logging] (rev 62784)
>
> This mail contains several logging-specific FindBugs errors in the
> lines of code that you last modified.
>
> We understand that there are a large number of these errors in
> "legacy" code that has not yet been modified to follow the logging
> guidelines described
> here:
> https://wikis.oracle.com/display/GlassFish/Logging+Guide
>
> We also understand that it may take some time for all code to be
> updated to follow these guidelines. The purpose of this reminder
> message is to notify you of these errors so that you may schedule the
> work to update the code as appropriate.
>
> For additional information, please visit the FindBugs page:
> http://wikis.oracle.com/display/GlassFish/FindBugs
>
> Thank you.
>
> Errors:
> ======================================================================
> ======
> ====
> jeremy_lv:
> appserver/web/web-core/src/main/java/org/apache/catalina/connector/Coy
> oteAda
> pter.java:304: GF_MISSING_LOGMESSAGE_INFO_ANNOTATION: Found log
> message ID with missing LogMessageInfo annotation.
> jeremy_lv:
> appserver/web/web-core/src/main/java/org/apache/catalina/connector/Coy
> oteAda
> pter.java:294: GF_MISSING_LOGMESSAGE_INFO_ANNOTATION: Found log
> message ID with missing LogMessageInfo annotation.
> jeremy_lv:
> appserver/ejb/ejb-container/src/main/java/com/sun/ejb/containers/BaseC
> ontain
> er.java:4112: GF_MISSING_LOGMESSAGE_INFO_ANNOTATION: Found log message
> ID with missing LogMessageInfo annotation.
> jeremy_lv:
> appserver/ejb/ejb-container/src/main/java/com/sun/ejb/containers/BaseC
> ontain
> er.java:4102: GF_MISSING_LOGMESSAGE_INFO_ANNOTATION: Found log message
> ID with missing LogMessageInfo annotation.
> jeremy_lv:
> nucleus/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluste
> r/Crea
> teInstanceCommand.java:252: GF_MISSING_LOGMESSAGE_INFO_ANNOTATION:
> Found log message ID with missing LogMessageInfo annotation.
>