These review comments should have come in the One Pager for GMS
Configuration.
The GMS team is targetting MS2 (Monday) for closing out on the
configuration related tasks and such feedback should have been posted
when the review solicitation was sent out on the dev list.
Some of the config entities were proposed as attributes earlier, but
properties was the preferred route as reviewed in the admin iteam
meeting a month or two ago.
On 6/17/10 1:24 PM, Rebecca Parks wrote:
> On 06/17/10 13:20, Anissa Lam wrote:
>>
>>
>> Bobby Bissett wrote:
>>> To meet our M2 goal, I could just promote these props to attributes.
>>> Anyone? Anyone?
>> I always prefer optional attributes than props. User doesn't need
>> to dig out the doc to find the exact property name. Much easier to
>> get/set in CLI and admin console.
>
> I agree. I write the doc that specifies the attribute and property
> names, and it's much easier to find an attribute name using the config
> analyzer than it is to pester an engineer for a property name.
>
> Rebecca
>>
>> Anissa.
>>>
>>> None of the examples I can find do this. It's not like I'm adding a
>>> child element (the list is already there), I can't find an example
>>> of a Property being created to add one manually. I'm running out of
>>> things to try....
>>>
>>> On Jun 17, 2010, at 1:23 PM, Bobby Bissett wrote:
>>>
>>>> Hi all,
>>>>
>>>> In Cluster.java I've added the property descriptor info to the
>>>> property child element:
>>>>
>>>> @ToDo(priority=ToDo.Priority.IMPORTANT, details="Complete
>>>> PropertyDesc for legal props" )
>>>> @PropertiesDesc(props={
>>>> @PropertyDesc(name="TCPSTARTPORT", defaultValue = "9090",
>>>> description = "GMS listener port range start value"),
>>>> @PropertyDesc(name="TCPENDPORT", defaultValue = "9120",
>>>> description = "GMS listener port range end value")
>>>> })
>>>> @Element
>>>> @Param(name="properties", optional=true)
>>>> @Override
>>>> List<Property> getProperty();
>>>>
>>>> But in the decorator called during "asadmin create-cluster <name>"
>>>> I get the list and see no properties in it. Can someone tell me
>>>> what I need to do to have these properties created?
>>>>
>>>> More importantly, I need to change the values in the decorator to
>>>> something including the cluster name, which isn't known of course
>>>> till runtime. If I need to add a property whose value isn't known
>>>> until runtime, is the above even the correct way to do it (declare
>>>> it on the element and then change it)? I could not figure out how
>>>> to create a new Property object to add to the list in the decorator.
>>>>
>>>> Thanks,
>>>> Bobby
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>