dev@glassfish.java.net

Re: upgrade pom.xml review request

From: Bobby Bissett <Robert.Bissett_at_Sun.COM>
Date: Thu, 24 Sep 2009 23:23:15 -0400

> First, thanks for updating the year in v3/pom.xml.
> Even though you defined the javax.help dependency in
> <dependencyManagement>, you also need to define it in extras/upgrade/
> upgrade-jar/pom.xml but without the version:
>
> <dependency>
> <groupId>javax.help</groupId>
> <artifactId>javahelp</artifactId>
> </dependency>
>
> I think this will solve your build issues.

Thanks, this is working (and. looking back, is exactly what Sahoo
suggested but I removed too much). Thanks for the info on why version
is moved to the top level but the artifact is in the leaf. It makes
sense once I know....

Build is fine now for me. One more time on the diffs below, let me
know if they still look ok.

hostname% svn diff pom.xml
Index: pom.xml
===================================================================
--- pom.xml (revision 31865)
+++ pom.xml (working copy)
@@ -3,7 +3,7 @@
  /*
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
  *
-* Copyright 1997-2007 Sun Microsystems, Inc. All rights reserved.
+* Copyright 1997-2009 Sun Microsystems, Inc. All rights reserved.
  *
  * The contents of this file are subject to the terms of either the GNU
  * General Public License Version 2 only ("GPL") or the Common
Development
@@ -998,6 +998,12 @@
              <artifactId>jersey-multipart</artifactId>
              <version>${jersey.version}</version>
          </dependency>
+
+ <dependency>
+ <groupId>javax.help</groupId>
+ <artifactId>javahelp</artifactId>
+ <version>2.0.02</version>
+ </dependency>
          </dependencies>
      </dependencyManagement>
      <!-- End: Dependency management -->




hostname% pwd
/Users/bobby/work/ws/v3/extras/upgrade/upgrade-jar
hostname% svn diff pom.xml
Index: pom.xml
===================================================================
--- pom.xml (revision 31865)
+++ pom.xml (working copy)
@@ -63,7 +63,7 @@
                               
<mainClass>com.sun.enterprise.tools.upgrade.UpgradeToolMain</mainClass>
                          </manifest>
                          <manifestEntries>
- <Class-Path>kernel.jar admin-cli.jar stax-
osgi.jar admin-cli-l10n.jar javahelp-2.0.02.jar</Class-Path>
+ <Class-Path>common-util.jar javahelp.jar</
Class-Path>
                          </manifestEntries>
                      </archive>
                  </configuration>
@@ -78,39 +78,8 @@
              <version>${project.version}</version>
          </dependency>
          <dependency>
- <groupId>org.glassfish.admin</groupId>
- <artifactId>admin-cli</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.glassfish.admin</groupId>
- <artifactId>cli-framework</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.glassfish.admin</groupId>
- <artifactId>server-mgmt</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.glassfish.deployment</groupId>
- <artifactId>deployment-common</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.glassfish.deployment</groupId>
- <artifactId>dol</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.glassfish.core</groupId>
- <artifactId>kernel</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
              <groupId>javax.help</groupId>
              <artifactId>javahelp</artifactId>
- <version>2.0.02</version>
          </dependency>
      </dependencies>
  </project>