Mitesh,
will any other modules outside of cmp itself (and appclient) now depend
on this newly introduced cmp-internal-api module?
Thanks,
Snjezana
Mitesh Meswani wrote:
> Please review following changes. A bunch of API classes are moved
> from persitence/cmp/support-sqlstore into a new module
> persistence/cmp/internal-api.(see [1]) These changes are to reduce
> foot print of appclient as described by issue 9515
> <https://glassfish.dev.java.net/issues/show_bug.cgi?id=9515>
> $ svn diff persistence/cmp/cmp-all/pom.xml
> Index: persistence/cmp/cmp-all/pom.xml
> ===================================================================
> --- persistence/cmp/cmp-all/pom.xml (revision 31380)
> +++ persistence/cmp/cmp-all/pom.xml (working copy)
> @@ -56,6 +56,11 @@
> <dependencies>
> <dependency>
> <groupId>${project.groupId}</groupId>
> + <artifactId>cmp-internal-api</artifactId>
> + <version>${project.version}</version>
> + </dependency>
> + <dependency>
> + <groupId>${project.groupId}</groupId>
> <artifactId>cmp-utility</artifactId>
> <version>${project.version}</version>
> </dependency>
> ----------------------------------------------------------------------------------------------------------------
>
> $ svn diff persistence/cmp/support-sqlstore/pom.xml
> Index: persistence/cmp/support-sqlstore/pom.xml
> ===================================================================
> --- persistence/cmp/support-sqlstore/pom.xml (revision 31380)
> +++ persistence/cmp/support-sqlstore/pom.xml (working copy)
> @@ -103,6 +103,11 @@
> <dependencies>
> <dependency>
> <groupId>org.glassfish.persistence.cmp</groupId>
> + <artifactId>cmp-internal-api</artifactId>
> + <version>${project.version}</version>
> + </dependency>
> + <dependency>
> + <groupId>org.glassfish.persistence.cmp</groupId>
> <artifactId>cmp-model</artifactId>
> <version>${project.version}</version>
> </dependency>
>
> ----------------------------------------------------------------------------------------------------------------
>
> $ cat persistence/cmp/internal-api/pom.xml
> <?xml version="1.0" encoding="UTF-8"?>
> <!--
> /*
> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
> *
> * Copyright 1997-2007 Sun Microsystems, Inc. All rights reserved.
> *
> * The contents of this file are subject to the terms of either the GNU
> * General Public License Version 2 only ("GPL") or the Common Development
> * and Distribution License("CDDL") (collectively, the "License"). You
> * may not use this file except in compliance with the License. You can
> obtain
> * a copy of the License at
> https://glassfish.dev.java.net/public/CDDL+GPL.html
> * or glassfish/bootstrap/legal/LICENSE.txt. See the License for the
> specific
> * language governing permissions and limitations under the License.
> *
> * When distributing the software, include this License Header Notice
> in each
> * file and include the License file at
> glassfish/bootstrap/legal/LICENSE.txt.
> * Sun designates this particular file as subject to the "Classpath"
> exception
> * as provided by Sun in the GPL Version 2 section of the License file
> that
> * accompanied this code. If applicable, add the following below the
> License
> * Header, with the fields enclosed by brackets [] replaced by your own
> * identifying information: "Portions Copyrighted [year]
> * [name of copyright owner]"
> *
> * Contributor(s):
> *
> * If you wish your version of this file to be governed by only the
> CDDL or
> * only the GPL Version 2, indicate your decision by adding "[Contributor]
> * elects to include this software in this distribution under the [CDDL
> or GPL
> * Version 2] license." If you don't indicate a single choice of
> license, a
> * recipient has the option to distribute your version of this file under
> * either the CDDL, the GPL Version 2 or to extend the choice of
> license to
> * its licensees as provided above. However, if you add GPL Version 2
> code
> * and therefore, elected the GPL Version 2 license, then the option
> applies
> * only if the new code is made subject to such option by the copyright
> * holder.
> */
> -->
> <project xmlns="http://maven.apache.org/POM/4.0.0"
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/maven-v4_0_0.xsd">
> <modelVersion>4.0.0</modelVersion>
> <parent>
> <groupId>org.glassfish.persistence.cmp</groupId>
> <artifactId>cmp</artifactId>
> <version>3.0-SNAPSHOT</version>
> </parent>
>
> <artifactId>cmp-internal-api</artifactId>
> <packaging>hk2-jar</packaging>
> <name>internal-api module for cmp</name>
>
> <developers>
> <developer>
> <id>mm110999</id>
> <name>Mitesh Meswani</name>
> <organization>Sun Microsystems, Inc.</organization>
> <roles>
> <role>developer</role>
> <role>lead</role>
> </roles>
> </developer>
> </developers>
>
> <dependencies>
> <dependency>
> <groupId>org.glassfish</groupId>
> <artifactId>javax.transaction</artifactId>
> <version>${project.version}</version>
> </dependency>
> <dependency>
> <groupId>org.glassfish.persistence</groupId>
> <artifactId>persistence-common</artifactId>
> <version>${project.version}</version>
> </dependency>
> </dependencies>
> </project>
>
> Thanks,
> Mitesh
>
> <https://glassfish.dev.java.net/issues/show_bug.cgi?id=9515>[1] Output
> of svn status under v3/v3/persistence/
> A internal-api
> A internal-api\src
> A internal-api\src\main
> A internal-api\src\main\java
> A internal-api\src\main\java\com
> A internal-api\src\main\java\com\sun
> A internal-api\src\main\java\com\sun\jdo
> R + internal-api\src\main\java\com\sun\jdo\api
> D + internal-api\src\main\java\com\sun\jdo\api\persistence
> D +
> internal-api\src\main\java\com\sun\jdo\api\persistence\support\util
> D +
> internal-api\src\main\java\com\sun\jdo\api\persistence\support\util\AugmentationTest.java
>
> A internal-api\pom.xml
> M cmp-all\pom.xml
> D support-sqlstore\src\main\java\com\sun\jdo\api
> D support-sqlstore\src\main\java\com\sun\jdo\api\persistence
> D support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\JDOObjectNotFoundException.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\FieldMapping.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\JDOFatalInternalException.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\JDOFatalUserException.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\JDODataStoreException.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\JDOFatalException.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\JDOCanRetryException.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\InstanceCallbacks.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\Query.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\PersistenceManagerFactory.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\SpecialDBOperation.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\JDOFatalDataStoreException.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\JDOHelper.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\PersistenceManager.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\JDOQueryException.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\Transaction.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\ConnectionFactory.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\JDODuplicateObjectIdException.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\JDOUserException.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\JDOException.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\PersistenceCapable.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\SynchronizationManager.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\JDOUnsupportedOptionException.java
>
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\util
> D
> support-sqlstore\src\main\java\com\sun\jdo\api\persistence\support\util\AugmentationTest.java
>
> A +
> support-sqlstore\src\main\java\com\sun\jdo\spi\persistence\support\sqlstore\utility\AugmentationTest.java
>
> M support-sqlstore\pom.xml
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>