Hi Dies,
You are correct, the changes were for registration. I am copying Siraj,
the owner for registration to check why these changes did not make into V2.1
Thanks,
Mitesh
Dies Koper wrote:
> Hi Mitesh, Kedar,
>
> It seem Mitesh also made a number of changes to V2UR1 that did not end
> up in V2.1:
> Please refer to revisions 1.31.4.1 to 1.31.4.5:
> http://fisheye5.atlassian.com/changelog/glassfish/appserv-core/src/java/com/sun/enterprise/admin/server/core
>
>
> Looking at the commit logs they seem to be related to the Registration
> function, but I'd just like to make sure nothing important got lost as
> there's over 40 lines of code changed in AdminService.java.
>
> Thanks,
> Dies
>
>
> Kedar Mhaswade wrote:
>> Dies,
>>
>> Memory fails me here, but I think the change-set you sent a pointer
>> to, refers to building the source with JDK 6 (or so says the checkin
>> log: "Checking in changes for JDK6 compilation").
>>
>> I am not sure why it was attempted as GF v2 needs to run with Java 5
>> and compiling it with Java 6 to create classes targeted for
>> Java 5 does not look necessary. From a cursory glance, all of the
>> changes are related to building/compilation.
>>
>> Sorry, I don't know the context here and I think this does not need
>> to be forward ported to 2.1.next.
>>
>> -Kedar
>>
>>
>>
>> Dies Koper wrote:
>>> Hi Kedar,
>>>
>>> I just sent the e-mail below to Dinesh Patil but noticed he hasn't been
>>> active on the GF mailing lists for quite a while.
>>>
>>> He made a change to GFv2UR1 that later was NOT included in GFv2.1.
>>> It looks like a mistake to me, but I'd like to make sure. (If it was,
>>> maybe it should be considered for inclusion in GFv2.1-next?)
>>>
>>> http://fisheye5.cenqua.com/changelog/glassfish/appserv-jstl?cs=SJSAS91_UR1_BRANCH:dpatil:20080206022354
>>>
>>>
>>> You are the project owner of the first few files he changed, so I
>>> thought I'd ask you first.
>>>
>>> Thanks,
>>> Dies
>>>
>>>
>>> Dies Koper wrote:
>>>> Hi Dinesh,
>>>>
>>>> In GFv2UR1 you made the following changes to help GlassFish compile
>>>> on JDK6.
>>>>
>>>> http://fisheye5.cenqua.com/changelog/glassfish/appserv-jstl?cs=SJSAS91_UR1_BRANCH:dpatil:20080206022354
>>>>
>>>>
>>>> In GFv2.1 these changes seem to be not included. Do you know the
>>>> reason why?
>>>>
>>>> Thanks,
>>>> Dies Koper
>
>