Hi Marina,
I'm happy to hear it went through! I checked in the change to the
pom.xml file... I can't say I fully understand it (exploding this adds
it to the classpath for later use for some reason). Please let me know
if you see any other problems building.
There are no tests for the dataprovider build (which is a repacking
build of the Woodstock dataprovider jar). I'm not sure which tests are
being skipped (perhaps tests for modules that don't define any?).
Thanks for helping test this out!
Ken
Marina Vatkina wrote:
> Hi Ken,
>
> With this pom.xml my build went through.
>
> I noticed that there were several skipped tests (where can I find
> which ones?) but that's probably irrelevant for this problem.
>
> thanks,
> -marina
>
> Ken Paulsen wrote:
>>
>> Hi,
>>
>> I didn't send out a changed one (Sahoo remarked on sending out
>> pom.xml's for review). However, I was wondering if expanding the .jar
>> would cause it to be part of the classpath for compiling. Attached is
>> one you can try that does this.
>>
>> I just blew away my .m2 directory and am in the process of doing a
>> clean checkout / build. With any luck, my build will fail. ;) Then I
>> can look into this more.
>>
>> Thanks!
>>
>> Ken
>>
>> Anissa Lam wrote:
>>
>>> Hi Marina/Kin-Man ,
>>>
>>> Since you can reproduce the build problem relating to dataprovider,
>>> can you help test if the pom.xml that Ken sent out for review
>>> actually fixes the issue. He attached that to the email sent to
>>> Sahoo earlier if you want to see whats the difference.
>>> I have also attached it here.
>>> This is to replace v3/admingui/dataprovider/pom.xml that you
>>> currently have.
>>>
>>> Kin-Man, if you have previously commented out <dataprovider> in
>>> admingui/pom.xml, you need to uncomment that to do the test.
>>>
>>> thanks
>>> Anissa
>>>
>>> Marina Vatkina wrote:
>>>
>>>> I'm also seeing this problem after I updated my ws. today :(.
>>>>
>>>> I'm on Solaris 10 x86, java version 1.5.0_16-b02.
>>>>
>>>> thanks,
>>>> -marina
>>>>
>>>> Sahoo wrote:
>>>>
>>>>> Anissa,
>>>>>
>>>>> Why is the version set to 4.2 in admingui/dataprovider/pom.xml?
>>>>> That's bad, because this artifact is built every time and hence we
>>>>> are likely to update the repository keeping the version number
>>>>> same. It should inherit its version from parent.
>>>>> I highly recommend people to send their pom.xmls to dev alias for
>>>>> review.
>>>>>
>>>>> Thanks,
>>>>> Sahoo
>>>>>
>>>>> Anissa Lam wrote:
>>>>>
>>>>>>
>>>>>> Many of you have seen this problem that failed in some system and
>>>>>> worked in other. What platform are you building on ? OS version ?
>>>>>> Java version ? mvn version ? Maybe we can see some commonalities
>>>>>> between the failed system.
>>>>>>
>>>>>> Does the class 'com.sun.data.provider.RowKey' exists in your
>>>>>> repository/org/glassfish/admingui/dataprovider/4.2/dataprovider-4.2.jar
>>>>>> which is specified as the dependency ?
>>>>>>
>>>>>> This jar is an OSGi bundle created by wrapping the
>>>>>> dataprovider.jar that comes from woodstock, which is not an OSGi
>>>>>> bundle. Can Sahoo help us take a look at this to see if there is
>>>>>> anything looks suspicious ?
>>>>>>
>>>>>> Can you try doing 'rm -rf
>>>>>> repository/org/glassfish/admingui/dataprovider' to remove the one
>>>>>> you build yourself,
>>>>>> and then edit admingui/pom.xml to remove building the
>>>>>> dataprovider module, forcing it to download from the maven
>>>>>> repository to see if makes any difference ?
>>>>>>
>>>>>> <modules>
>>>>>> <module>dataprovider</module> <==== remove this module
>>>>>> <module>jsftemplating</module>
>>>>>> <module>plugin-service</module>
>>>>>> <module>common</module>
>>>>>> <module>core</module>
>>>>>> <module>web</module>
>>>>>> <module>jdbc-gui</module>
>>>>>> <module>security</module>
>>>>>> <module>war</module>
>>>>>> </modules>
>>>>>>
>>>>>>
>>>>>> Harsha, will you be able to help out on this issue that more and
>>>>>> more people is facing since admingui is now part of the v3 build ?
>>>>>>
>>>>>> Sorry, i have more questions than answers :)
>>>>>>
>>>>>>
>>>>>> thaniks
>>>>>> Anissa
>>>>>>
>>>>>>
>>>>>> Shalini Muthukrishnan wrote:
>>>>>>
>>>>>>> I faced the same issue on a freshly built workspace. As per
>>>>>>> Anissa's previous mail, i checked the contents of my .m2
>>>>>>> repository:
>>>>>>>
>>>>>>> #ls -ltr ~/.m2/repository/org/glassfish/admingui/dataprovider/4.2
>>>>>>> -rw-r--r-- 1 shalini shalini 327 2008-08-07 18:00
>>>>>>> dataprovider-4.2-sources.jar
>>>>>>> -rw-r--r-- 1 shalini shalini 4773 2008-08-07 18:00
>>>>>>> dataprovider-4.2.pom
>>>>>>> -rw-r--r-- 1 shalini shalini *106012* 2008-08-07 18:00
>>>>>>> dataprovider-4.2.jar
>>>>>>>
>>>>>>> The size of the dataprovider-4.2.jar seems different from what
>>>>>>> was mentioned in the email :
>>>>>>> -rw-r--r-- 1 anilam staff *105980* Aug 5 13:01 dataprovider-4.2.jar
>>>>>>>
>>>>>>> I tried copying dataprovider-4.2.jar with size "*105980*" from
>>>>>>> another workspace into my repository and i still see these errors.
>>>>>>> I checked out my workspace 2 hours back. Any workarounds for
>>>>>>> this? I need to perform certain tests for my code changes with
>>>>>>> admin GUI so i need to build this module.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Shalini.
>>>>>>>
>>>>>>> V B Kumar Jayanti wrote:
>>>>>>>
>>>>>>>> Any thoughts on how to fix this ?.
>>>>>>>>
>>>>>>>> E:\FRESH\V3\Aug07\v3\admingui\core\src\main\java\org\glassfish\admingui\handlers
>>>>>>>>
>>>>>>>> \TableHandlers.java:144: cannot find symbol
>>>>>>>> symbol : class RowKey
>>>>>>>> location: class org.glassfish.admingui.handlers.TableHandlers
>>>>>>>> RowKey[] keys = (RowKey []) handlerCtx.getInputValue("rowKeys");
>>>>>>>> ^
>>>>>>>> E:\FRESH\V3\Aug07\v3\admingui\core\src\main\java\org\glassfish\admingui\handlers
>>>>>>>>
>>>>>>>> \TableHandlers.java:144: cannot find symbol
>>>>>>>> symbol : class RowKey
>>>>>>>> location: class org.glassfish.admingui.handlers.TableHandlers
>>>>>>>> RowKey[] keys = (RowKey []) handlerCtx.getInputValue("rowKeys");
>>>>>>>> ^
>>>>>>>> E:\FRESH\V3\Aug07\v3\admingui\core\src\main\java\org\glassfish\admingui\handlers
>>>>>>>>
>>>>>>>> \TableHandlers.java:146: inconvertible types
>>>>>>>> found : java.lang.Object
>>>>>>>> required:
>>>>>>>> com.sun.jsftemplating.component.dataprovider.MultipleListDataProvider
>>>>>>>>
>>>>>>>> (MultipleListDataProvider) trg.getSourceData();
>>>>>>>> ^
>>>>>>>> E:\FRESH\V3\Aug07\v3\admingui\core\src\main\java\org\glassfish\admingui\handlers
>>>>>>>>
>>>>>>>> \TableHandlers.java:147: cannot find symbol
>>>>>>>> symbol : class RowKey
>>>>>>>> location: class org.glassfish.admingui.handlers.TableHandlers
>>>>>>>> for (RowKey key : keys) {
>>>>>>>> ^
>>>>>>>> E:\FRESH\V3\Aug07\v3\admingui\core\src\main\java\org\glassfish\admingui\handlers
>>>>>>>>
>>>>>>>> \TableHandlers.java:165: inconvertible types
>>>>>>>> found : java.lang.Object
>>>>>>>> required:
>>>>>>>> com.sun.jsftemplating.component.dataprovider.MultipleListDataProvider
>>>>>>>>
>>>>>>>> (MultipleListDataProvider) trg.getSourceData();
>>>>>>>> ^
>>>>>>>> E:\FRESH\V3\Aug07\v3\admingui\core\src\main\java\org\glassfish\admingui\handlers
>>>>>>>>
>>>>>>>> \TableHandlers.java:254: inconvertible types
>>>>>>>> found : java.lang.Object
>>>>>>>> required:
>>>>>>>> com.sun.jsftemplating.component.dataprovider.MultipleListDataProvider
>>>>>>>>
>>>>>>>> MultipleListDataProvider dp =
>>>>>>>> (MultipleListDataProvider)trg.getSourceDat
>>>>>>>> a();
>>>>>>>>
>>>>>>>> ^
>>>>>>>> E:\FRESH\V3\Aug07\v3\admingui\core\src\main\java\org\glassfish\admingui\handlers
>>>>>>>>
>>>>>>>> \TableHandlers.java:287: inconvertible types
>>>>>>>> found : java.lang.Object
>>>>>>>> required:
>>>>>>>> com.sun.jsftemplating.component.dataprovider.MultipleListDataProvider
>>>>>>>>
>>>>>>>> MultipleListDataProvider dp =
>>>>>>>> (MultipleListDataProvider)trg.getSourceDat
>>>>>>>> a();
>>>>>>>>
>>>>>>>> ^
>>>>>>>> Note: Some input files use unchecked or unsafe operations.
>>>>>>>> Note: Recompile with -Xlint:unchecked for details.
>>>>>>>> 15 errors
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>> ------------------------------------------------------------------------
>>
>> <?xml version="1.0" encoding="UTF-8"?>
>> <!-- /* * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER. *
>> * Copyright 1997-2008 Sun Microsystems, Inc. All rights reserved.
>> * * The contents of this file are subject to the terms of either the
>> GNU * General Public License Version 2 only ("GPL") or the Common
>> Development * and Distribution License("CDDL") (collectively, the
>> "License"). You * may not use this file except in compliance with the
>> License. You can obtain * a copy of the License at
>> https://glassfish.dev.java.net/public/CDDL+GPL.html * or
>> glassfish/bootstrap/legal/LICENSE.txt. See the License for the
>> specific * language governing permissions and limitations under the
>> License. * * When distributing the software, include this License
>> Header Notice in each * file and include the License file at
>> glassfish/bootstrap/legal/LICENSE.txt. * Sun designates this
>> particular file as subject to the "Classpath" exception * as provided
>> by Sun in the GPL Version 2 section of the License file that *
>> accompanied this code. If applicable, add the following below the
>> License * Header, with the fields enclosed by brackets [] replaced by
>> your own * identifying information: "Portions Copyrighted [year] *
>> [name of copyright owner]" * * Contributor(s): * * If you wish your
>> version of this file to be governed by only the CDDL or * only the
>> GPL Version 2, indicate your decision by adding "[Contributor] *
>> elects to include this software in this distribution under the [CDDL
>> or GPL * Version 2] license." If you don't indicate a single choice
>> of license, a * recipient has the option to distribute your version
>> of this file under * either the CDDL, the GPL Version 2 or to extend
>> the choice of license to * its licensees as provided above. However,
>> if you add GPL Version 2 code * and therefore, elected the GPL
>> Version 2 license, then the option applies * only if the new code is
>> made subject to such option by the copyright * holder. */ -->
>> <project xmlns="http://maven.apache.org/POM/4.0.0"
>> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
>> http://maven.apache.org/maven-v4_0_0.xsd">
>> <parent>
>> <groupId>org.glassfish</groupId>
>> <artifactId>glassfish-parent</artifactId>
>> <version>10.0-SNAPSHOT</version>
>> </parent>
>>
>> <!-- version 4.0 means this is the dataprovider used in Woodstock 4.2
>> release -->
>> <groupId>org.glassfish.admingui</groupId>
>> <artifactId>dataprovider</artifactId>
>> <name>DataProvider</name>
>> <version>4.2</version>
>> <modelVersion>4.0.0</modelVersion>
>> <description>DataProvider Repackaged as OSGi bundle for
>> GlassFish</description>
>>
>> <packaging>jar</packaging>
>> <build>
>> <plugins>
>> <plugin>
>> <!-- Configure maven-bundle-plugin which takes care of
>> OSGi packaging -->
>> <!-- We need to override the plugin settings -->
>> <groupId>org.apache.felix</groupId>
>> <artifactId>maven-bundle-plugin</artifactId>
>> <!-- We don't use extensions as this interfers with
>> hk2-maven-plugin and that results in hk2 artifacts
>> being copied as .hk2-jar. Instead, we configure the
>> plugin to run as part of package phase. By Sahoo.
>> <extensions>true</extensions>
>> -->
>> <configuration>
>> <instructions>
>> <Embed-Dependency>artifactId=dataprovider;inline=true;</Embed-Dependency>
>>
>> <Export-Package>com.sun.data.*;</Export-Package>
>> <Import-Package>com.sun.sql.*;resolution:=optional,*</Import-Package>
>> </instructions>
>> <unpackBundle>true</unpackBundle>
>> </configuration>
>> <executions>
>> <execution>
>> <id>osgi-bundle</id>
>> <phase>package</phase>
>> <goals>
>> <goal>bundle</goal>
>> </goals>
>> </execution>
>> </executions>
>> </plugin>
>> </plugins>
>> </build>
>> <repositories>
>> <repository>
>> <id>glassfish-repository</id>
>> <name>Java.net Repository for Glassfish</name>
>> <url>http://download.java.net/maven/glassfish</url>
>> <snapshots>
>> <updatePolicy>never</updatePolicy>
>> </snapshots>
>> </repository>
>> </repositories>
>> <dependencies>
>> <dependency>
>> <groupId>com.sun.woodstock.dependlibs</groupId>
>> <artifactId>dataprovider</artifactId>
>> <version>1.0</version>
>> <scope>compile</scope>
>> </dependency>
>> </dependencies>
>> </project>
>