Hi Sahoo,
The dataprovider bundle is currently a repackaged bundle from a
woodstock .jar file. The bits don't change, so we are setting the
version to 4.2. Why should this be any different? I hope to avoid the
repackaging step at some point, but that will have to wait until I fix
the Woodstock build to produce OSGi bundles. Replacing the 4.2 version
of dataprovider with itself shouldn't be a problem, should it?
The pom.xml is attached for review... please let me know if you see
anything that should be changed.
I've tried to reproduce the error, but have not been able to do it w/
Ubuntu + Java 5 or Java 6. I'm very concerned that our build can't
reproduce consistent results -- why is that?
Sahoo, in the past, you wrote this:
... This is happening, because maven tries to use
target/classes in compiler classpath for projects that are same in the
same maven reactor and maven-bundle-plugin does not extract the
repackaged jar in target/classes unless asked to do so. That's why, if
you look at any of the distributions/pom.xml, we actually configure
maven-bundle-plugin to extract the jar like this:
(taken from v3/distributions/external/sysnet-registration/pom.xml)
* <!-- Maven uses the output directory
(target/classes)
rather than the final bundle, when compiling against
projects in the same reactor (ie. the same build).
Since this jar comprises of classes that come from
some other jar and other modules depend on this
artifact, we need to unpack.
-->
<unpackBundle>true</unpackBundle>
*
Check maven-bundle-plugin documentation for more details. If you do
this in the pom.xml where you are repackaging jsftemplating, your
problem would be solved.
Perhaps this needs to be added to our the dataprovider pom.xml? I'd
test... but I can't reproduce the problem.
Ken
Sahoo wrote:
Anissa,
Why is the version set to 4.2 in admingui/dataprovider/pom.xml? That's
bad, because this artifact is built every time and hence we are likely
to update the repository keeping the version number same. It should
inherit its version from parent.
I highly recommend people to send their pom.xmls to dev alias for
review.
Thanks,
Sahoo
Anissa Lam wrote:
Many of you have seen this problem that failed in some system and
worked in other. What platform are you building on ? OS version ?
Java version ? mvn version ? Maybe we can see some commonalities
between the failed system.
Does the class 'com.sun.data.provider.RowKey' exists in your
repository/org/glassfish/admingui/dataprovider/4.2/dataprovider-4.2.jar
which is specified as the dependency ?
This jar is an OSGi bundle created by wrapping the dataprovider.jar
that comes from woodstock, which is not an OSGi bundle. Can Sahoo
help us take a look at this to see if there is anything looks
suspicious ?
Can you try doing 'rm -rf
repository/org/glassfish/admingui/dataprovider' to remove the one you
build yourself,
and then edit admingui/pom.xml to remove building the dataprovider
module, forcing it to download from the maven repository to see if
makes any difference ?
<modules>
<module>dataprovider</module> <==== remove
this module
<module>jsftemplating</module>
<module>plugin-service</module>
<module>common</module>
<module>core</module>
<module>web</module>
<module>jdbc-gui</module>
<module>security</module>
<module>war</module>
</modules>
Harsha, will you be able to help out on this issue that more and more
people is facing since admingui is now part of the v3 build ?
Sorry, i have more questions than answers :)
thaniks
Anissa
Shalini Muthukrishnan wrote:
I faced the same issue on a freshly built
workspace. As per Anissa's previous mail, i checked the contents of my
.m2 repository:
#ls -ltr ~/.m2/repository/org/glassfish/admingui/dataprovider/4.2
-rw-r--r-- 1 shalini shalini 327 2008-08-07 18:00
dataprovider-4.2-sources.jar
-rw-r--r-- 1 shalini shalini 4773 2008-08-07 18:00
dataprovider-4.2.pom
-rw-r--r-- 1 shalini shalini *106012* 2008-08-07 18:00
dataprovider-4.2.jar
The size of the dataprovider-4.2.jar seems different from what was
mentioned in the email :
-rw-r--r-- 1 anilam staff *105980* Aug 5 13:01
dataprovider-4.2.jar
I tried copying dataprovider-4.2.jar with size "*105980*" from another
workspace into my repository and i still see these errors.
I checked out my workspace 2 hours back. Any workarounds for this? I
need to perform certain tests for my code changes with admin GUI so i
need to build this module.
Thanks,
Shalini.
V B Kumar Jayanti wrote:
Any thoughts on how to fix this ?.
E:\FRESH\V3\Aug07\v3\admingui\core\src\main\java\org\glassfish\admingui\handlers
\TableHandlers.java:144: cannot find symbol
symbol : class RowKey
location: class org.glassfish.admingui.handlers.TableHandlers
RowKey[] keys = (RowKey []) handlerCtx.getInputValue("rowKeys");
^
E:\FRESH\V3\Aug07\v3\admingui\core\src\main\java\org\glassfish\admingui\handlers
\TableHandlers.java:144: cannot find symbol
symbol : class RowKey
location: class org.glassfish.admingui.handlers.TableHandlers
RowKey[] keys = (RowKey []) handlerCtx.getInputValue("rowKeys");
^
E:\FRESH\V3\Aug07\v3\admingui\core\src\main\java\org\glassfish\admingui\handlers
\TableHandlers.java:146: inconvertible types
found : java.lang.Object
required:
com.sun.jsftemplating.component.dataprovider.MultipleListDataProvider
(MultipleListDataProvider) trg.getSourceData();
^
E:\FRESH\V3\Aug07\v3\admingui\core\src\main\java\org\glassfish\admingui\handlers
\TableHandlers.java:147: cannot find symbol
symbol : class RowKey
location: class org.glassfish.admingui.handlers.TableHandlers
for (RowKey key : keys) {
^
E:\FRESH\V3\Aug07\v3\admingui\core\src\main\java\org\glassfish\admingui\handlers
\TableHandlers.java:165: inconvertible types
found : java.lang.Object
required:
com.sun.jsftemplating.component.dataprovider.MultipleListDataProvider
(MultipleListDataProvider) trg.getSourceData();
^
E:\FRESH\V3\Aug07\v3\admingui\core\src\main\java\org\glassfish\admingui\handlers
\TableHandlers.java:254: inconvertible types
found : java.lang.Object
required:
com.sun.jsftemplating.component.dataprovider.MultipleListDataProvider
MultipleListDataProvider dp =
(MultipleListDataProvider)trg.getSourceDat
a();
^
E:\FRESH\V3\Aug07\v3\admingui\core\src\main\java\org\glassfish\admingui\handlers
\TableHandlers.java:287: inconvertible types
found : java.lang.Object
required:
com.sun.jsftemplating.component.dataprovider.MultipleListDataProvider
MultipleListDataProvider dp =
(MultipleListDataProvider)trg.getSourceDat
a();
^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
15 errors
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: dev-help@glassfish.dev.java.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: dev-help@glassfish.dev.java.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: dev-help@glassfish.dev.java.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: dev-help@glassfish.dev.java.net