dev@woodstock.java.net

Re: Fwd: Woodstock

From: Lyle T. Harris <Lyle.Harris_at_Sun.COM>
Date: Thu, 18 Sep 2008 10:34:55 -0700

I found a bug in com.sun.webui.jsf.renderkit.widget.AccordionTabRenderer
around line 168 where null IDs are not handled well resulting in the
dreaded NPE:

[#|2008-09-18T10:01:05.536-0700|SEVERE|sun-appserver9.1|javax.enterprise.system.container.web|_ThreadID=24;_ThreadName=httpSSLWorkerThread-8080-3;_RequestID=67be67ed-3643-4d70-9263-5ccd4bd5e0b3;|StandardWrapperValve[FacesServlet]:
PWC1406: Servlet.service() for servlet FacesServlet threw exception
java.lang.NullPointerException
        at
com.sun.webui.jsf.renderkit.widget.AccordionTabRenderer.appendChildProps(AccordionTabRenderer.java:168)
        at
com.sun.webui.jsf.renderkit.widget.AccordionTabRenderer.getProperties(AccordionTabRenderer.java:130)
        at
com.sun.webui.jsf.renderkit.widget.RendererBase.encodeChildren(RendererBase.java:134)


Current code:

           for (UIComponent kid : component.getChildren()) {
                if (!kid.getId().equals("selectedState")) {
                    jArray.put(WidgetUtilities.renderComponent(context,
kid));
                }
            }

Proposed Enhancement:

           for (UIComponent kid : component.getChildren()) {
                if (!"selectedState".equals(kid.getId())) {
                    jArray.put(WidgetUtilities.renderComponent(context,
kid));
                }
            }

Couldn't seem to find a place on the woodstock page to submit a
bug, or bug fix, although it probably doesn't matter since nobody's
home. The "contribute bug fix" page is also unfinished.

I'm a member of the woodstock project but have never submitted
any code changes since I don't believe I am that level of contributor.

Any what the best way to affect a change like this might be?

Regards,