dev@woodstock.java.net

Re: Please Reivew: Fix for Issue #68

From: Dan Labrecque - Sun Microsystems <Dan.Labrecque_at_Sun.COM>
Date: Tue, 10 Apr 2007 22:27:03 -0400

Looks fine to me.

Dan

Ken Paulsen wrote:
>
> Issue #68 is a simple fix. The "styleSheet" property is currently
> ignored. It should skip the .css files when true. The following
> change checks for this property and skips rendering the .css files
> when it is true. The fix has been confirmed to work by the original
> submitter.
>
> Please approve this change and I'll commit the fix to the head.
>
> Thanks!
>
> Ken
>
>
> cvs diff ThemeLinksRenderer.java
> Index: ThemeLinksRenderer.java
> ===================================================================
> RCS file:
> /cvs/woodstock/webui/src/runtime/com/sun/webui/jsf/renderkit/html/ThemeLinksRenderer.java,v
>
> retrieving revision 1.1
> diff -r1.1 ThemeLinksRenderer.java
> 66,71c66,73
> < Theme theme = ThemeUtilities.getTheme(context);
> < if (themeLinks.isStyleSheetInline()) {
> < RenderingUtilities.renderStyleSheetInline(themeLinks,
> theme, context, writer);
> < } else if (themeLinks.isStyleSheetLink()) {
> < RenderingUtilities.renderStyleSheetLink(themeLinks,
> theme, context, writer);
> < }
> ---
> > if (themeLinks.isStyleSheet()) {
> > Theme theme = ThemeUtilities.getTheme(context);
> > if (themeLinks.isStyleSheetInline()) {
> > RenderingUtilities.renderStyleSheetInline(themeLinks,
> theme, context, writer);
> > } else if (themeLinks.isStyleSheetLink()) {
> > RenderingUtilities.renderStyleSheetLink(themeLinks,
> theme, context, writer);
> > }
> > }
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_woodstock.dev.java.net
> For additional commands, e-mail: dev-help_at_woodstock.dev.java.net
>