jsr369-experts@servlet-spec.java.net

[jsr369-experts] Re: Renaming HttpServletRequest#getPushBuilder to #newPushBuilder.

From: Mark Thomas <markt_at_apache.org>
Date: Fri, 24 Mar 2017 09:57:27 +0000

On 23/03/17 22:16, Shing Wai Chan wrote:
> We had the pleasure of discussing HTTP/2 push with Simone Bordet yesterday. He suggested that we rename HttpServletRequest#getPushBuilder() to HttpServletRequest#newPushBuilder().
>
> This is a good idea as we have the following in javadoc of PushBuilder:
>
> A PushBuilder is obtained by calling HttpServletRequest.getPushBuilder(). Each call to this method will return a new instance of a PushBuilder based off the current HttpServletRequest. Any mutations to the returned PushBuilder are not reflected on future returns.
>
> What do you think?

No objections.

Mark