jsr369-experts@servlet-spec.java.net

[jsr369-experts] Re: request character encoding in web.xml (SERVLET_SPEC-161)

From: Mark Thomas <markt_at_apache.org>
Date: Tue, 14 Mar 2017 20:16:40 +0000

On 14/03/17 17:27, Shing Wai Chan wrote:
> Any comments on the renaming the xml elements defined lately
> from request-encoding/response-encoding to request-character-enocoding/response-character-encoding?

I prefer the proposed naming as it is consistent.

Mark


>
> Thanks.
> Shing Wai Chan
>
>> On Mar 9, 2017, at 11:43 AM, Shing Wai Chan <shing.wai.chan_at_oracle.com> wrote:
>>
>> In our previous discussion of https://java.net/jira/browse/SERVLET_SPEC-161
>> ("Allow encoding to be set from deployment descriptor and API”), we decide to the following:
>>
>> a) add #get/setRequestCharacterEncoding and #get/setResponseCharacterEncoding in ServletContext
>> b) add <request-encoding>, <response-encoding> in web.xml
>>
>> Note that we have get/setCharacterEncoding in ServletRequest/ServletResponse, etc.
>> In other words, we have “characterEncoding” rather than just “Encoding" in our API.
>> If that is the case, then it is better to rename the new xml elements in web.xml as follows:
>> <request-character-encoding>
>> <response-character-encoding>
>>
>> Please let me know if you have any opinion.
>> Thanks.
>> Shing Wai Chan
>>
>>
>