dev@javaserverfaces.java.net

Re: [REVIEW/629] jsf 1.2 and <jsp:param> not working

From: Adam Winer <adam.winer_at_oracle.com>
Date: Fri, 21 Sep 2007 10:29:02 -0700

Ryan Lubke said the following on 9/21/07 12:03 AM PT:
> Adam Winer wrote:
>> I'm frankly amazed at the claim this worked in 1.1.
>> The EL in 1.1 was bound to ExternalContext.getRequestParameterMap(),
>> which is always the ServletRequest parameter map, *not* the
>> current JSP parameter map - or was there magic in 1.1 that I didn't
>> know about?
> Not following you here Adam. What JSP parameteter map?
> When a JSP include is performed and it specifies parameters, those
> params will be present for the life of the include via the ServletRequest.

Hrm - I always guessed that it was a different ServletRequest
instance that gets created for the include to add the needed
parameters, instead of the servlet engine hacking into
its own object to add and then later remove the parameters.
(It's how I'd implement a servlet engine, at any rate.)
Does the servlet spec really require it's the same instance
across includes?

> Because of that, and how we build/rendered the tree in 1.1, it works.

If and only if:
   - It's guaranteed to be the same ServletRequest instance
   - You didn't have a rendersChildren parent in the parent page
     around the include

-- Adam

>
>>
>> -- Adam
>>
>>
>> Ryan Lubke wrote:
>>> Change bundle attached to the issue [1].
>>> Please note I've added additional comments to the issue for
>>> consideration
>>> after having had attached the change bundle.
>>>
>>>
>>> [1] https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=629
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
>>> For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
>> For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
> For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
>