>>>>> On Fri, 13 Jan 2017 16:08:03 +0100, arjan tijms <arjan.tijms_at_gmail.com> said:
AT> Hi,
AT> I took a look at the Spec1238IT test and the @JsfTest annotation was indeed
AT> missing. Perhaps would be best to add it and then try to test again? It
AT> should be:
AT> @JsfTest(value = JSF_2_3_0_M10, excludes = {WEBLOGIC_12_1_4,
AT> WEBLOGIC_12_2_1})
Ok, I just ran the test manually by hand on a WLS 12.2.1 patched with my
just-built Mojarra with the changes. I know it's in there due to our
trusty log message:
Initializing Mojarra 2.3.0-m10 (-SNAPSHOT 20170114-0801 unable to get svn info) for context '/test-javaee8-searchExpression'>
(We should fix that "unable to get svn info" message. The intent of
that was to include the svn revision into the build. That build logic
needs to be reworked to show the most recent git revision hash instead.)
I loaded up the page from the new test and here's the source in
question.
<label id="label" for="input">Test</label>
<input id="input" type="text" name="input" onchange="mojarra.ab(this,event,'valueChange',0,'_at_this input2')" />
<input id="input2" type="text" name="input2" />
Looking at the assertions in the test:
HtmlLabel label = (HtmlLabel) page.getHtmlElementById("label");
HtmlTextInput input = (HtmlTextInput) page.getHtmlElementById("input");
Assert.assertEquals(label.getAttribute("for"), input.getId());
Assert.assertTrue(input.getAttribute("onchange").contains("@this input2"));
It looks like they are true.
I'm going to try to get a clean run on GlassFish 4.1.1 and if it works
I'll commit it. If it fails on WLS again, I'll mark it ignore on WLS as
Arjan suggested.
Ed
--
| edward.burns_at_oracle.com | office: +1 407 458 0017
| 6 business days until planned start of JSF 2.3 Public Review
| 26 business days until DevNexus 2017
| 51 business days until JavaLand 2017