jsr372-experts@javaserverfaces-spec-public.java.net

[jsr372-experts] Re: [SPEC-1238] request for review (was: Re: [PROPOSAL] CDI integration for UIComponent instances in JSF 2.3)

From: arjan tijms <arjan.tijms_at_gmail.com>
Date: Fri, 13 Jan 2017 16:08:03 +0100

Hi,

I took a look at the Spec1238IT test and the @JsfTest annotation was indeed
missing. Perhaps would be best to add it and then try to test again? It
should be:

@JsfTest(value = JSF_2_3_0_M10, excludes = {WEBLOGIC_12_1_4,
WEBLOGIC_12_2_1})

Kind regards,
Arjan Tijms




On Fri, Jan 13, 2017 at 3:49 PM, arjan tijms <arjan.tijms_at_gmail.com> wrote:

> Hi,
>
>
> On Fri, Jan 13, 2017 at 3:45 PM, Edward Burns <edward.burns_at_oracle.com>
> wrote:
>
>> >>>>> On Wed, 11 Jan 2017 08:39:14 -0800, Edward Burns <
>> edward.burns_at_oracle.com> said:
>> All right it is committed, but it broke the CI builds on WLS 12.2.1.
>>
>
> Is it a test from that changeset that doesn't run on WLS 12.2.1? If so, it
> probably hasn't gotten the special WLS marker that most or all tests need.
> It may work again by only adding that.
>
> Kind regards,
> Arjan Tijms
>
>
>
>
>> I promised Manfred I'd revert it if there was any breakage, so I am
>> bound to revert it, so I will do so and move it into a feature branch
>> matching the JIRA. I'll continue to debug it.
>>
>> Ed
>>
>> --
>> | edward.burns_at_oracle.com | office: +1 407 458 0017
>> | 6 business days until planned start of JSF 2.3 Public Review
>> | 26 business days until DevNexus 2017
>> | 51 business days until JavaLand 2017
>>
>
>