jsr372-experts@javaserverfaces-spec-public.java.net

[jsr372-experts] Re: [JAVASERVERFACES_SPEC_PUBLIC-1066] Task - JavaDoc for Application#getNavigationHandler() method does not mention the navigation-handler within the application element of faces-config

From: manfred riem <manfred.riem_at_oracle.com>
Date: Fri, 04 Sep 2015 09:04:52 -0500

Hi Neil,

Your suggested change has been applied.

Thanks!

Kind regards,
Manfred Riem

On 9/3/15, 3:05 PM, Neil Griffin wrote:
> Hi Manfred,
>
> I just updated JAVASERVERFACES_SPEC_PUBLIC-1066 with some suggested
> JavaDoc for Application.getNavigationHandler() based on the JavaDoc
> from Application.getResourceHandler().
>
> When I created the issue back in 2012, I became aware of the JavaDoc
> oversight in getNavigationHandler() because I had to implement a
> NavigationHandler for the JSF Portlet Bridge. I was not aware of the
> oversight in other methods like getMessageBundle(), etc. as Bauke
> mentions below.
>
>
> Best Regards,
>
> Neil
>
>> On Aug 27, 2015, at 6:12 AM, Bauke Scholtz <balusc_at_gmail.com
>> <mailto:balusc_at_gmail.com>> wrote:
>>
>> Well, there are more missing. E.g. getMessageBundle() doesn't mention
>> <application><message-bundle>, getResourceBundle() doesn't mention
>> <application><resource-bundle>, getDefaultRenderKitId() doesn't
>> mention <application><default-render-kit-id>, getActionListener()
>> doesn't mention <application><action-listener>.
>>
>> I agree we should align out the javadoc as much as possible, but I
>> wonder why the user was mentioning only the navigation handler.
>>
>> Cheers, B
>>
>> On Wed, Aug 26, 2015 at 4:15 PM, manfred riem
>> <manfred.riem_at_oracle.com <mailto:manfred.riem_at_oracle.com>> wrote:
>>
>> Hi Neil,
>>
>> Can you please suggest what you would like to see in the JavaDoc
>> here?
>>
>> See https://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1066
>>
>> Thanks!
>>
>> Kind regards,
>> Manfred Riem
>>
>>
>