Salut,
+1
The branch is 1_9_18e
Thanks
-- Jeanfrancois
Nandini Ektare wrote:
> Hi,
>
> Could someone please review this change?
> In v2 the constraints levied on acceptor-threads attribute stated a
> range of 1 to NA
> For some reason the existing config used a default of -1 (I am assuming
> it was a typo)
>
> GF Issue corresponding to this is
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=9953
>
> Thanks,
> Nandini
> PS: What is the branch I need to checkin this one and are there any
> special process related instructions I need to bear in mind (or tests to
> be run in adition to QL) before committing?
>
>
>> Author: ne110415
>> Date: 2009-10-07 00:02:41+0000
>> New Revision: 3726
>> Modified:
>> trunk/code/modules/config/src/main/java/com/sun/grizzly/config/dom/Transport.java
>> Log:
>> Fix for 9953. acceptor-threads had a value range of 1,NA in v2 and
>> apparently the default was supposed to be 1. The default in the bean
>> however has been set to -1. With this fix, manpages will be in sync
>> with command operation with defaults.
>> Modified:
>> trunk/code/modules/config/src/main/java/com/sun/grizzly/config/dom/Transport.java
>> Url: https://grizzly.dev.java.net/source/browse/grizzly/trunk/code/modules/config/src/main/java/com/sun/grizzly/config/dom/Transport.java?view=diff&rev=3726&p1=trunk/code/modules/config/src/main/java/com/sun/grizzly/config/dom/Transport.java&p2=trunk/code/modules/config/src/main/java/com/sun/grizzly/config/dom/Transport.java&r1=3725&r2=3726
>> <https://grizzly.dev.java.net/source/browse/grizzly/trunk/code/modules/config/src/main/java/com/sun/grizzly/config/dom/Transport.java?view=diff&rev=3726&p1=trunk/code/modules/config/src/main/java/com/sun/grizzly/config/dom/Transport.java&p2=trunk/code/modules/config/src/main/java/com/sun/grizzly/config/dom/Transport.java&r1=3725&r2=3726>
>> ==============================================================================
>> ---
>> trunk/code/modules/config/src/main/java/com/sun/grizzly/config/dom/Transport.java
>> (original)
>> +++
>> trunk/code/modules/config/src/main/java/com/sun/grizzly/config/dom/Transport.java
>> 2009-10-07 00:02:41+0000
>> @@ -56,7 +56,7 @@
>> /**
>> * The number of acceptor threads listening for the transport's events
>> */
>> - @Attribute(defaultValue = "-1", dataType = Integer.class)
>> + @Attribute(defaultValue = "1", dataType = Integer.class)
>> String getAcceptorThreads();
>> void setAcceptorThreads(String value);
>> @@ -179,4 +179,4 @@
>> }
>> -}
>> \ No newline at end of file
>> +}