From: Bongjae Chang <carryel_at_korea.com>
Date: Mon, 11 May 2009 13:25:17 +0900

Hi,

When I used the connection management cache with CacheableConnectorHandlerPool, the connection which was once failed couldn't reconnect the remote endpoint.

It seems that the pool always stores the connector handler without checking the validity.

If you try to connect the invalid remote which was shut down for a while, and if you try to reconnect the remote after it revives, you can always see the following error.

-----
java.nio.channels.ClosedChannelException
        at java.nio.channels.spi.AbstractSelectableChannel.register(AbstractSelectableChannel.java:1
94)
        at java.nio.channels.SelectableChannel.register(SelectableChannel.java:277)
        at com.sun.grizzly.connectioncache.client.CacheableConnectorHandler.notifyCallbackHandlerPse
udoConnect(CacheableConnectorHandler.java:199)
        at com.sun.grizzly.connectioncache.client.CacheableConnectorHandler.doConnect(CacheableConne
ctorHandler.java:161)
        at com.sun.grizzly.connectioncache.client.CacheableConnectorHandler.connect(CacheableConnect
orHandler.java:115)
        at SimpleTestServerForCache.sendTcpTest(SimpleTestServerForCache.java:154)
        at SimpleTestServerForCache$1.run(SimpleTestServerForCache.java:51)
        at java.lang.Thread.run(Thread.java:717)
-----

Then, maybe you can't connect the remote any longer regardless of the remote's state.

So, I think that the cacheable pool should try to check the connector handler's validity when the connector handler is released and the pool should not return the connector handler to idle connections if the handler is not connected.

Here is the sample.

In OutboundConnectionCacheBlockingImpl.java,
-----
public synchronized void release( final C conn, final int numResponsesExpected ){
   ...
   final ConnectionState<C> cs = connectionMap.get( conn );
   try {
      if( cs == null ) {
         ...
         return;
      } else {
         ...
         if(numBysy == 0 ) {
            ...
            if(isConnected( conn ) && !connectionClosed )
            //if(!connectionClosed) {
               ...
               entry.idleConnections.offer( conn );
               cs.csv = ConnectionStateValue.IDLE;
            }
         }
      }

   }
   ...
}

@SuppressWarnings( "unchecked" )
private boolean isConnected( final C conn ) {
   if( conn instanceof TCPConnectorHandler ) {
      return ((TCPConnectorHandler)conn).isConnected();
   } else if ( conn instanceof UDPConnectorHandler ) {
      return ((UDPConnectorHandler)conn).isConnected();
   } else if ( conn instanceof SSLConnectorHandler ) {
      return ((SSLConnectorHandler)conn).isConnected();
   } else {
      return true;
   }
}
-----

If ConnectorHandlers' isConnected() method is moved into higher position like AbstractConnectorHandler class or ConnectorHandler interface as I said from the former mail(https://grizzly.dev.java.net/servlets/ReadMsg?list=dev&msgNo=2591), the patch could perhaps be simpler.

Thanks.

--
Bongjae Chang