dev@grizzly.java.net

Re: [Fwd: [Issue 53] AttributeHolder needs maps with parameterized types <T>]

From: Oleksiy Stashok <Oleksiy.Stashok_at_Sun.COM>
Date: Fri, 15 Feb 2008 21:47:43 +0100

> I disagree :-(
>
> Reason.. think about a generic use-case of Collections (since you are
> using a Map..) in the places where we /Grizzly is using Keys .. for
> example, in SlectorHandler, Collector, Context... What would be the
> BEST to describe an attribute in a collection, in the context of
> grizzly's Context, SelectorHandler, Controller? does it really a
> String type?
I think String is good compromise. IMHO Object is much worse in this
case! And I don't see how we can make Map's key parameter parametrized.
It will mean anyone can break existing code.

> Actually, the way Grizzly using the *term* attribute is not even
> appropriate. Why? attribute is something that describes a specific
> distinguishable feature of the particular object (or instance). The
> way grizzly uses here is, to store SOME objects and their references,
> in case it needs at various scopes.
I agree with Jeanfrancois. I'm not talking about theoretical "attribute"
meaning, as not sure it's right place, but, IMHO <String, Object>
representation of attribute storage is used very often..

> This forces users to "create" their own strings?keys (to accommodate
> in) to retrieve the references.
Right.

> Take the case of grizzly's Context which ALSO acts as an AttributeHolder.
> If I read the API for the latest Context.java... what does it say -
> "Used to share objects b/w ProtocolFilter"
> Now, if I want to use this place-holder to STORE my objects , what's
> the best way to identify my collection of Objects in a Grizzly's
> Context. Does it really a String?
Why not <"MY_COLLECTION", Collection<?>> ?

> Since we can not go back, now we ought to stick to the one in place.
> Thats where we are.
That's also true :)

Thanks!

WBR,
Alexey.
>
> -hg
>
>
>
>
>
>>
>>
>>>
>>> Thanks.
>>>
>>> WBR,
>>> Alexey.
>>>
>>> ------------------------------------------------------------------------
>>>
>>>
>>> Subject:
>>> [Issue 53] AttributeHolder needs maps with parameterized types <T>
>>> From:
>>> jfarcand_at_dev.java.net
>>> Date:
>>> Thu, 14 Feb 2008 22:28:23 +0000
>>> To:
>>> issues_at_grizzly.dev.java.net
>>>
>>> To:
>>> issues_at_grizzly.dev.java.net
>>>
>>>
>>> https://grizzly.dev.java.net/issues/show_bug.cgi?id=53
>>>
>>>
>>>
>>> User jfarcand changed the following:
>>>
>>> What |Old value |New value
>>> ================================================================================
>>>
>>> Priority|P1 |P3
>>> --------------------------------------------------------------------------------
>>>
>>>
>>>
>>>
>>>
>>> ------- Additional comments from jfarcand_at_dev.java.net Thu Feb 14
>>> 22:28:23 +0000 2008 -------
>>> Not a p1 IMO
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: issues-unsubscribe_at_grizzly.dev.java.net
>>> For additional commands, e-mail: issues-help_at_grizzly.dev.java.net
>>>
>>>
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_grizzly.dev.java.net
>>> For additional commands, e-mail: dev-help_at_grizzly.dev.java.net
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_grizzly.dev.java.net
>> For additional commands, e-mail: dev-help_at_grizzly.dev.java.net
>>
>