users@glassfish.java.net

Re: GlassFish v3 logging one pager ready for review

From: <glassfish_at_javadesktop.org>
Date: Fri, 30 Jan 2009 11:19:56 PST

More comments.

10. Each property should have its default, min, max or acceptable values described.
I will add this info.

11. Can properties be specified as ${SERVER_NAME} and be substituted with a real value? (I assume not). This is an interesting issue when applied against different servers and clusters.
Nope.

12. What provisions are being made to ensure that high-intensity logging does not become a contested lock?
I'll update the description in the one pager as this seems to be confusing.

13. Are there provisions for efficiently emitting batches of log messages under high load in a separate thread (writing 100 messages to a file at once can be far more efficient than one at a time).
This was suggested above and I will add this.

14. "file" is more than a file: it's a path and a file. Do we want to have a separate path vs filename? Do we really want to allow a filename that is other than server.log?
"file" is used because it is already in v2 and v3 Prelude and it does allow a path and filename. We are providing it because it is already there in v2.

15. How are platform-specific paths handled? What happens if a domain uses C:\domain1\logs\server.log and another server in a cluster is on unix? Is there a canonical form for the pathname?
users are allowed to change the filename (and the path) but the location is relative to the domain. As far as I can see you just can't put the file anywhere on the system.

16. "Custom handlers are added to the root logger and available to all applications running on the server. Custom filters are added to each logger known to the system at startup". Please elaborate. There can be more than one? What is the delimiter and which property defines them?
For handlers yes using a space delimiter but for filter only one. I will clarify.

What if the same handler or filter is listed more than once? Is there a priority order?

All handlers are added. The JDK is doing the work and I assume they are added in the order listed.
[Message sent by forum member 'carlavmott' (carlavmott)]

http://forums.java.net/jive/thread.jspa?messageID=329296