quality@glassfish.java.net

Re: Few samples fail to deploy in the latest nightly build of GlassFish

From: Judy Tang <Judy.J.Tang_at_Sun.COM>
Date: Mon, 16 Nov 2009 18:25:48 -0800

Don't know what is better than can't be better, it started with finding
a bad bug in the promote build,
ended with adding a unit test to cover it. Richard and Jan rock !

Thanks
Judy

Jan Luehe wrote:
> Hi Richard,
>
> On 11/15/09 22:27, Richard Kolb wrote:
>> Hi Jan
>>
>> I had a look at my pom.xml and in there lies the issue
>> The JSF and Servlet API's were being put in the WAR
>> Changed them to provided and now it works.
>
> Excellent! After adding jsf-api.jar to my test application's WEB-INF/lib
> directory, I was finally able to reproduce the original issue.
>
> I've committed the test case to our unit test repository.
>
> Thanks so much for your help!
>
> Jan
>
>
>>
>> Here is the pom.xml now. Attached to issue
>>
>> regards
>> Richard.
>>
>>
>>
>> 2009/11/16 Richard Kolb <rjdkolb_at_gmail.com <mailto:rjdkolb_at_gmail.com>>
>>
>> Hi Jan
>>
>> I see your war does deploy and mine does not on build 72.
>> Have you tried the maven project I attached ?
>> (war is 3.9meg)
>>
>> Also can you supply the source code of your test please ?
>>
>> thanks
>> Richard
>>
>> 2009/11/16 Richard Kolb <rjdkolb_at_gmail.com
>> <mailto:rjdkolb_at_gmail.com>>
>>
>> Hi Jan
>>
>> thanks. I will try in B72 (the build that caused the issue)
>> and report back.
>>
>> regards
>> Richard
>>
>> 2009/11/13 Jan Luehe <Jan.Luehe_at_sun.com
>> <mailto:Jan.Luehe_at_sun.com>>
>>
>> Hi Richard,
>>
>> I've been trying to further simplify your test webapp
>> attached to IT 10992
>> <https://glassfish.dev.java.net/issues/show_bug.cgi?id=10992>
>> and incorporate it into a unit test, so that the kind of
>> regression we've been
>> seen won't go unnoticed before any future promotions.
>>
>> I've come up with the attached test.war, but for some
>> reason, I'm unable
>> to reproduce the error when I deploy it.
>>
>> Could you please take a look and let me know what the app
>> is missing
>> in order to trigger the error?
>>
>> Thanks a lot,
>>
>> Jan
>>
>>
>> On 11/12/09 22:55, Judy Tang wrote:
>>> Hi Richard,
>>>
>>> Thanks for spending time to simplify the tests and
>>> attach to the issue. This
>>> is a big help, can't be better :-)
>>>
>>> Judy
>>>
>>> Richard Kolb wrote:
>>>> Hi Paul
>>>>
>>>> There is a sample maven app attached to my bug :
>>>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=10992
>>>>
>>>> regards
>>>> Richard
>>>>
>>>> 2009/11/12 Paul Sandoz <Paul.Sandoz_at_sun.com
>>>> <mailto:Paul.Sandoz_at_sun.com>>
>>>>
>>>> Hi Richard,
>>>>
>>>> Note that the samples Naresh pointed to do not
>>>> utilize JSF.
>>>>
>>>> The bookmark sample uses some JPA features. And the
>>>> bookstore sample uses JSP features. I dunno what is
>>>> common to both that is causing the same deployment
>>>> failure.
>>>>
>>>> Paul.
>>>>
>>>> On Nov 12, 2009, at 10:55 AM, Richard Kolb wrote:
>>>>
>>>>> Hi Naresh
>>>>>
>>>>> It seems this is needed to recreate :
>>>>> Add a JSF backing bean like mine
>>>>>
>>>>>
>>>>> @ManagedBean(name="loadReduction")
>>>>> @SessionScoped
>>>>> public class LoadReductionBackingBean {
>>>>> }
>>>>>
>>>>> regards
>>>>> Richard.
>>>>>
>>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail:
>> quality-unsubscribe_at_glassfish.dev.java.net
>> <mailto:quality-unsubscribe_at_glassfish.dev.java.net>
>> For additional commands, e-mail:
>> quality-help_at_glassfish.dev.java.net
>> <mailto:quality-help_at_glassfish.dev.java.net>
>>
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: quality-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: quality-help_at_glassfish.dev.java.net
>