I copied this POM from an existing test, so I can't really tell you
why it's in there twice (though the first dep is on a plugin). I did,
though, remove the dep on plugin, leaving only the main dep, and all
QL tests continued to pass, so it doesn't seem to have been important/
necessary. With that change, are you comfortable with me committing
the change to this pom?
FWIW, in case you're tracking this type of changes, I modified the
console tests to remove the tests that checked for the frameset, as
the console is no longer frame-based.
On Mar 13, 2009, at 6:38 PM, Jane Young wrote:
> Hi Jason,
>
> The admingui/war/pom.xml looks fine.
>
> In tests/quicklook/adminconsole/pom.xml, there are two places
> declaring the testng dependency. Maybe one of the dependency should
> be removed? Can someone from QA take a look at this?
>
> Thanks,
> Jane
>
>
> Jason Lee wrote:
>>
>> Below are changes to two console-related pom files. The first
>> updates the Scales dep to the current product version, and the
>> second modifies the QL testng dep to drop the jdk5 classifier:
>>
>> Index: admingui/war/pom.xml
>> ===================================================================
>> --- admingui/war/pom.xml (revision 25379)
>> +++ admingui/war/pom.xml (working copy)
>> @@ -75,7 +75,7 @@
>> <dependency>
>> <groupId>com.sun.mojarra</groupId>
>> <artifactId>mojarra-scales</artifactId>
>> - <version>1.1</version>
>> + <version>1.2</version>
>> <scope>compile</scope>
>> </dependency>
>> <dependency>
>> Index: tests/quicklook/adminconsole/pom.xml
>> ===================================================================
>> --- tests/quicklook/adminconsole/pom.xml (revision 25379)
>> +++ tests/quicklook/adminconsole/pom.xml (working copy)
>> @@ -97,8 +97,7 @@
>> <dependency>^M
>> <groupId>org.testng</groupId>^M
>> <artifactId>testng</artifactId>^M
>> - <version>5.6</version>^M
>> - <classifier>jdk15</classifier>^M
>> + <version>5.8</version>^M
>> </dependency>^M
>> <dependency>^M
>> <groupId>com.sun.jsftemplating</groupId>^M
>> @@ -114,7 +113,6 @@
>> <groupId>org.testng</groupId>^M
>> <artifactId>testng</artifactId>^M
>> <version>5.8</version>^M
>> - <classifier>jdk15</classifier>^M
>> </dependency>^M
>> <dependency>^M
>> <groupId>commons-httpclient</groupId>^M
>>
>> Jason Lee
>> Senior Java Developer
>> GlassFish Administration Console
>>
>> Sun Microsystems, Inc.
>> Phone x31197/+1 405-343-1964
>> Email jasondlee_at_sun.com
>> Blog http://blogs.sun.com/jasondlee
>> Blog http://blogs.steeplesoft.com
>
Jason Lee
Senior Java Developer
GlassFish Administration Console
Sun Microsystems, Inc.
Phone x31197/+1 405-343-1964
Email jasondlee_at_sun.com
Blog
http://blogs.sun.com/jasondlee
Blog
http://blogs.steeplesoft.com