quality@glassfish.java.net

Re: [ACTION] Please review these admin console pom changes

From: Jane Young <Jane.Young_at_Sun.COM>
Date: Fri, 13 Mar 2009 16:38:17 -0700

Hi Jason,

The admingui/war/pom.xml looks fine.

In tests/quicklook/adminconsole/pom.xml, there are two places declaring
the testng dependency. Maybe one of the dependency should be removed?
Can someone from QA take a look at this?

Thanks,
Jane


Jason Lee wrote:
> Below are changes to two console-related pom files. The first updates
> the Scales dep to the current product version, and the second modifies
> the QL testng dep to drop the jdk5 classifier:
>
> Index: admingui/war/pom.xml
> ===================================================================
> --- admingui/war/pom.xml (revision 25379)
> +++ admingui/war/pom.xml (working copy)
> @@ -75,7 +75,7 @@
> <dependency>
> <groupId>com.sun.mojarra</groupId>
> <artifactId>mojarra-scales</artifactId>
> - <version>1.1</version>
> + <version>1.2</version>
> <scope>compile</scope>
> </dependency>
> <dependency>
> Index: tests/quicklook/adminconsole/pom.xml
> ===================================================================
> --- tests/quicklook/adminconsole/pom.xml (revision 25379)
> +++ tests/quicklook/adminconsole/pom.xml (working copy)
> @@ -97,8 +97,7 @@
> <dependency>^M
> <groupId>org.testng</groupId>^M
> <artifactId>testng</artifactId>^M
> - <version>5.6</version>^M
> - <classifier>jdk15</classifier>^M
> + <version>5.8</version>^M
> </dependency>^M
> <dependency>^M
> <groupId>com.sun.jsftemplating</groupId>^M
> @@ -114,7 +113,6 @@
> <groupId>org.testng</groupId>^M
> <artifactId>testng</artifactId>^M
> <version>5.8</version>^M
> - <classifier>jdk15</classifier>^M
> </dependency>^M
> <dependency>^M
> <groupId>commons-httpclient</groupId>^M
>
> <http://www.java.com> * Jason Lee *
> Senior Java Developer
> GlassFish Administration Console
>
> *Sun Microsystems, Inc.*
> Phone x31197/+1 405-343-1964
> Email jasondlee_at_sun.com <mailto:jasondlee_at_sun.com>
> Blog http://blogs.sun.com/jasondlee
> Blog http://blogs.steeplesoft.com
>
>