Hi Kedar,
I added a new QL test using your framework to verify the fix for IT 5706.
Here are my comments:
1. It actually took me more than 2mins to create the test but it's due
to my lack of knowledge of TestNG plus other issues relating too
create-file-user command.
2. The test I added was for create-file-user command. This is a
special command that requires userpassword to be encoded using
BASE64Encoder so I had to add common-util as a dependency in pom.xml:
Index: pom.xml
===================================================================
--- pom.xml (revision 22329)
+++ pom.xml (working copy)
@@ -86,6 +86,11 @@
<version>3.0.1</version>
</dependency>
<dependency>
+ <groupId>org.glassfish.common</groupId>
+ <artifactId>common-util</artifactId>
+ <version>10.0-SNAPSHOT</version>
+ </dependency>
+ <dependency>
<groupId>org.testng</groupId>
<artifactId>testng</artifactId>
<version>5.6</version>
3. Is there a way to just execute the test that you wrote instead of
running the entire QL tests?
4. How do you test negative test case? Currently, I just verify the
content of the Manifest object. Is that right?
BTW: I have not committed the QL test I added. I'm not sure if I can
add a dependency in QL's pom.xml. Please let me know if this is okay.
Jane
Kedar Mhaswade wrote:
> I have increased the coverage of v3 QL test suite by 60%! :-P
>
> No kidding, but now the number of tests is (only) 24 in number (from
> an earlier 15). All these tests are written to test asadmin commands.
> So, if you have written an AdminCommand, consider adding a test
> to test it out. IMO, adding an asadmin command test is easier than
> ever before and is documented at [1]. This is because I ended up
> writing a small framework to write tests for remote asadmin commands.
> It's
> still being improved to handle some corner cases, but you should be
> able to test your asadmin command out.
>
> I am looking for feedback.
>
> See https://glassfish.dev.java.net/issues/show_bug.cgi?id=5760 for
> details.
>
> Regards,
> Kedar
>
> 1- http://tinyurl.com/5q3pzh
>
> PS - Sorry if you received multiple copies of this message.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>