Hi Sahoo,
Sanjeeb Kumar Sahoo wrote On 10/13/06 20:01,:
> Marina Vatkina wrote:
>
>>3. MetadataProcessor
>> a) handleORMException
>> b) buildEntityList -> "exception_loading_entity_class"
>>=> should this be an exception or at least a warning instead?
>>
>>4. EntityManagerSetupImpl
>> a) buildEntityList -> same as 3b) above (Sahoo, why do we have 2
>>methods doing
>>the same thing?)
>
> They are *not* doing the same thing.
> EntityManagerSetupImpl.buildEntityList() calls
> MetadataProject.getEntityNames() to get the names of entities and then
> builds the list of entity classes by loading classes using the supplied
> CL. MetadataProcessor.buildEntityList() is used to populate
> MetadataProject with the list of entity names.
It also loads the classes via 'm_loader.loadClass(className)', right?
Shouldn't MetadataProcessor.buildEntityList() be renamed as it locates
and builds the list?
thanks,
-marina
We can rename
> EntityManagerSetupImpl.buildEntityList() to something else to avoid such
> confusion.
>
> Thanks,
> Sahoo