persistence@glassfish.java.net

Re: code review for issue #925

From: Guy Pelletier <guy.pelletier_at_oracle.com>
Date: Wed, 6 Sep 2006 09:05:34 -0400

Hi Sahoo,

You'll need to remove the 'return result' from your try block otherwise you
won't throw your exception for the relationship mapping to an embeddable
case.

The aggregate collection check is not necessary since we never build those
mappings for EJB 3.0

Otherwise, looks fine to me.

Cheers,
Guy

----- Original Message -----
From: "Sanjeeb Kumar Sahoo" <Sanjeeb.Sahoo_at_Sun.COM>
To: "Guy Pelletier" <guy.pelletier_at_oracle.com>;
<persistence_at_glassfish.dev.java.net>
Sent: Wednesday, September 06, 2006 12:07 AM
Subject: code review for issue #925


> Hi Guy,
>
> Would you mind reviewing the attached changes to fix issue #925?
>
> Thanks,
> Sahoo
>