From: Michael Bouschen <Michael.Bouschen_at_Sun.COM>
Date: Mon, 25 Sep 2006 15:39:33 +0200

Hi Wonseok,

thanks for the hint, good catch!

I fixed the two issues and checked in the change:
http://fisheye5.cenqua.com/changelog/glassfish/?cs=MAIN:mb124283:20060925123937

Regards Michael
> Hi Michael,
>
> This is not important thing, but I found that your test code missed
> adding a newly-added test to the test suite.
>
> The "simpleUnqualifiedUpdate" test method is added in addition to
> "updateEmbedded", but it is not added to the suite.
> Also, there are typos in line 239 and 250 - "perioid" should be "period".
> http://fisheye5.cenqua.com/browse/glassfish/entity-persistence-tests/src/java/oracle/toplink/essentials/testing/tests/ejb/ejbqltesting/JUnitEJBQLModifyTestSuite.java?r1=1.2&r2=1.3
> <http://fisheye5.cenqua.com/browse/glassfish/entity-persistence-tests/src/java/oracle/toplink/essentials/testing/tests/ejb/ejbqltesting/JUnitEJBQLModifyTestSuite.java?r1=1.2&r2=1.3>
>
> Regards
> -Wonseok
>
> On 9/18/06, *Michael Bouschen* <Michael.Bouschen_at_sun.com
> <mailto:Michael.Bouschen_at_sun.com>> wrote:
>
> Hi Tom, hi Jielin,
>
> I fixed issue 1124 "EJB3.0: Embedded object and path in UPDATE
> statement":
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=1124
> <https://glassfish.dev.java.net/issues/show_bug.cgi?id=1124>
>
> The attached jar JPQL-updateEmbeddeds-060918.jar includes the code
> changes and new tests in entity-persistence-tests. I extended the
> parse
> to accept a path expression including more than one dot. I also added
> some validation code to the parser node class EqualsAssignmentNode. It
> disallows updating a collection valued relationship field and
> navigating
> through a relationship field in the target expression of the SET
> clause.
>
> Thanks!
>
> Regards Michael
>
>
>